Skip to content

Get the full list of fields on the other methods #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Get the full list of fields on the other methods #28

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
991a90d
Get the full list of fields on the other methods
Mte90 Sep 17, 2025
1c49089
Add 'retrieve' action to fields check
Mte90 Sep 22, 2025
403bbb1
Update turbodrf/views.py
Mte90 Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions turbodrf/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ def get_serializer_class(self):
else:
fields_to_use = fields

if self.action not in ["list", "detail", "retrieve"]:
fields_to_use = "__all__"
Comment on lines +195 to +196
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic unconditionally overrides fields_to_use for all non-read actions, ignoring the previously calculated field configuration from lines 182-193.

Looking at lines 186-189, the code already handles write operations (create, update, partial_update) by using the detail fields configuration, which is the appropriate behavior. This new code will override that logic and force __all__ fields for these operations.

Additionally, the condition excludes "detail" but not "retrieve", which are typically equivalent actions in DRF. This inconsistency is problematic because:

  1. "retrieve" is the standard DRF action name for getting a single object
  2. "detail" is not a standard DRF action name

This will break the existing field configuration logic for models that define different fields for list and detail views (like SampleModel in the tests). For write operations, this might expose fields that should only be visible in detail views, or force all model fields to be serialized when only a subset was intended.

Suggested change
if self.action not in ["list", "detail", "retrieve"]:
fields_to_use = "__all__"

Copilot uses AI. Check for mistakes.
Copy link
Author

@Mte90 Mte90 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the point to show all the fields that are defined in turbodrf @copilot


# Store original fields before processing
original_fields = (
fields_to_use if isinstance(fields_to_use, list) else fields_to_use
Expand Down