Skip to content

Conversation

@AprilYUZhang
Copy link

No description provided.

isSexChrom = peelingInfo.isSexChrom

e = 0.000001
e = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert back please.



def writeDosages(pedigree, genoProbFunc, isSexChrom, outputFile):
def writeDosages(pedigree, genoProbFunc, isSexChrom, outputFile): # remove isSexChrom,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the comment

peelingInfo.segregationTensor = ProbMath.generateSegregation(e=1e-06)
peelingInfo.segregationTensor_norm = ProbMath.generateSegregation(
e=1e-06, partial=True
peelingInfo.segregationTensor = ProbMath.generateSegregation_mu(mu=mutation_rate)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProbMath.generateSegregation_mu --> ProbMath.generateSegregation

Copy link
Member

@gregorgorjanc gregorgorjanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the comments

@gregorgorjanc gregorgorjanc changed the title Sex chrom X chromosome functionality May 16, 2025
@gregorgorjanc
Copy link
Member

@AprilYUZhang add also a line to CHANGELOG like you did for tinyhouse.

@AprilYUZhang
Copy link
Author

AprilYUZhang commented Jun 4, 2025

@AprilYUZhang add also a line to CHANGELOG like you did for tinyhouse.

@gregorgorjanc It might cause the conflict with Ros's branch, because devel didn't have CHANGELOG.md. I can write here temporarily.

## [1.2.1] - 2025-06-04
**New features**
*add ``mutation_rate`, to allow users to input mutation rate ({pr}`192`, {user}`AprilYuZhang`)
* add ``x_chr`` to replace ``sex_chr`` and  users impute data on the x chromosome ({pr}`192`, {user}`AprilYuZhang`)
**Maintenance**
* Functional and accuracy tests for X chromosome ({pr}`192`, {user}`AprilYuZhang`)

@XingerTang
Copy link
Contributor

@AprilYUZhang could you update the tinyhouse reference and see if the tests pass

@AprilYUZhang
Copy link
Author

@XingerTang now the tests passed

@XingerTang
Copy link
Contributor

@AprilYUZhang Thanks! Could you trigger the pipeline here so that the GitHub runner runs your test?

@AprilYUZhang
Copy link
Author

@XingerTang it run automatically at my repository, but here I don't know why. I didn't modify any setting, I think maybe need maintainer's approve.
Screenshot 2025-11-05 at 13 04 26

@XingerTang
Copy link
Contributor

@AprilYUZhang This is weird. Could you close this and open a new pull request to see if it works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment