-
Notifications
You must be signed in to change notification settings - Fork 12
X chromosome functionality #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/tinypeel/Peeling/Peeling.py
Outdated
| isSexChrom = peelingInfo.isSexChrom | ||
|
|
||
| e = 0.000001 | ||
| e = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert back please.
src/tinypeel/Peeling/PeelingIO.py
Outdated
|
|
||
|
|
||
| def writeDosages(pedigree, genoProbFunc, isSexChrom, outputFile): | ||
| def writeDosages(pedigree, genoProbFunc, isSexChrom, outputFile): # remove isSexChrom, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the comment
src/tinypeel/Peeling/PeelingInfo.py
Outdated
| peelingInfo.segregationTensor = ProbMath.generateSegregation(e=1e-06) | ||
| peelingInfo.segregationTensor_norm = ProbMath.generateSegregation( | ||
| e=1e-06, partial=True | ||
| peelingInfo.segregationTensor = ProbMath.generateSegregation_mu(mu=mutation_rate) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ProbMath.generateSegregation_mu --> ProbMath.generateSegregation
gregorgorjanc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at the comments
|
@AprilYUZhang add also a line to CHANGELOG like you did for tinyhouse. |
@gregorgorjanc It might cause the conflict with Ros's branch, because devel didn't have CHANGELOG.md. I can write here temporarily. |
|
@AprilYUZhang could you update the tinyhouse reference and see if the tests pass |
|
@XingerTang now the tests passed |
|
@AprilYUZhang Thanks! Could you trigger the pipeline here so that the GitHub runner runs your test? |
|
@XingerTang it run automatically at my repository, but here I don't know why. I didn't modify any setting, I think maybe need maintainer's approve. |
|
@AprilYUZhang This is weird. Could you close this and open a new pull request to see if it works? |

No description provided.