2850 remove api23 support #2887
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
seabornlee
commented
Oct 28, 2022
seabornlee
commented
- Remove version check code
- Use original web3j lib
- Use stream API anyMatch
- Use Stream.mapToInt
- Use stream API
- Use stream API filter.count
- Use stream API mapToInt
- Use stream mapToInt
- Refactor: elimate for loop duplication
- Use stream noneMatch API
- Use stream findFirst API
seabornlee
force-pushed
the
2850-remove-api23-support
branch
from
be68fdb to
5fb051d
Compare
JamesSmartCell
force-pushed
the
master
branch
from
e967340 to
32f6049
Compare
JamesSmartCell
approved these changes
Oct 31, 2022
Member
JamesSmartCell
left a comment
JamesSmartCell
left a comment
There was a problem hiding this comment.
Looks good to me, will double check the test before merge.
JamesSmartCell
force-pushed
the
master
branch
2 times, most recently
from
a1cfb4f to
8acd3f7
Compare
Member
|
@seabornlee can you check why the tests were failing (probably an incidental thing) and rebase this to latest master so we can finally merge it? |
Contributor
Author
Ok. |
Member
|
@seabornlee could you rebase this PR so we can merge it? |
Contributor
Author
Ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.