Skip to content
This repository was archived by the owner on Dec 8, 2022. It is now read-only.

Refactor Internal Setter smell in BaseActivity class #768

Open
emaiannone wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor Internal Setter smell in BaseActivity class #768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/com/github/andlyticsproject/BaseActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public void startActivity(Class<?> clazz, boolean disableAnimation, boolean skip
intent.setFlags(Intent.FLAG_ACTIVITY_NO_ANIMATION);
}
if (skipDataReload) {
setSkipMainReload(true);
this.skipMainReload = true;
Copy link
Member

@AndyScherzinger AndyScherzinger Mar 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually this. isn't needed

Copy link
Member

@AndyScherzinger AndyScherzinger Mar 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

@emaiannone emaiannone Mar 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AndyScherzinger and thank you for your reply. I only applied a single example of MIM, I know that there might be some other instances, but I didn't want to apply too many changes at once.
Yes, whenever all references of setter are remove even the method itself could be remove, but currently aDoctor doesn't support this feature.

}

startActivity(intent);
Expand Down