Skip to content

Conversation

@SamC-Apadmi
Copy link
Collaborator

This change has no effect on the mobile builds, but once deployed to the desktop application it will mean it supports both the short and the long keys.

Once the new desktop app has been out for a while, we can swap over the encoding to use the short keys.

This change has no effect on the mobile builds, but once deployed to the desktop application it will mean it supports both the short and the long keys.

Once the new desktop app has been out for a while, we can swap over the encoding to use the short keys.
Copy link
Collaborator

@chedabob chedabob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can still keep these readable whilst keeping under the 9 character limit?

Something like?

    val appName: String,
    @JsonNames("appPkg", "appPackage")
    val appPackage: String,
    @JsonNames("osVersion", "operatingSystemVersion")
    val operatingSystemVersion: String,
    @JsonNames("devModel", "deviceModel")
    val deviceModel: String,
    @JsonNames("appVer", "appVersion")
    val appVersion: String,
    val runTarget: RunTarget? = null,
    @JsonNames("mzVersion", "mockzillaVersion")
    val mockzillaVersion: String

@SamC-Apadmi
Copy link
Collaborator Author

Can still keep these readable whilst keeping under the 9 character limit?

Yeah I tried but I didn't like that I couldn't think of ways of cutting them down which felt consistent, in the end I figured the raw packages aren't read by humans very much, and the smaller the data parcel the better right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants