[WIP] Fully convert project to Kotlin #413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As pull requests from a fork doesn't run screenshot compare tests, I'll make a pull request with given changes on upstream |
|
Please see #414 |
# Conflicts: # MPChartLib/src/main/java/com/github/mikephil/charting/charts/CombinedChart.kt
zacharee
force-pushed
the
feat/multiplatform
branch
from
938d078 to
d70e065
Compare
|
I fixed the unit tests and ported in the divide by 0 fix. |
|
Brought it back down to Java 17. There was some clashing with defaults that made me set it to 21, but 17 seems to work locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts all Java source files to Kotlin. The initial pass was done with Android Studio's automatic converter with manual changes made afterwards to fix errors and improve nullability indicators. Some code paths were also changed to better work with Kotlin.
I did some testing, but I'm sure there are bugs or unintended behavior changes I missed, so I'm marking this as work-in-progress and hoping to have others help test it.
The new codebase is also not API-compatible with the old version. Some of the changes can be tweaked so generated Java setter names match what they used to be, but Kotlin consumers will have to change to property access syntax, and the way Kotlin's generics work required adding more generic types to some classes.