Add PairwiseDocNewUIESA Page #161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snukky
requested changes
Jul 22, 2024
Contributor
snukky
left a comment
snukky
left a comment
There was a problem hiding this comment.
Thanks for this PR! It looks good, but I have a few small suggestions before we merge:
- We can drop "-newui" or "NewUI" from the class/method/URL names for simplicity.
- I would like you to try introducing the new model class through inheritance instead of copy-pasting the entire class. I believe it's doable, but please feel free to object.
- We should add a new regression test in
RegressionTests/tests/examplesto make sure we don't break it in future. It may be helpful to do it before addressing the points above. - Can you also briefly check if none of the PRs pulled today to the develop branch didn't change any logic in ESA tasks, which you use here?
I will then take another look. Thank you :)
snukky
approved these changes
Aug 19, 2024
Contributor
snukky
left a comment
snukky
left a comment
There was a problem hiding this comment.
Thank you very much for this PR! Everything seems to look good. Can you only summarize changes in the model file here (see one of the comments)? I think it may be useful for future reference.
I'd like to merge it after we finish WMT campaigns, which should be very soon.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PairwiseDocNewUIESA Page