Skip to content

Conversation

EricGustin
Copy link
Member

@EricGustin EricGustin commented Oct 13, 2025

Blocked by #614 (and the reason for failing tests)

PR Description

arcade deploy will deploy your local MCP server to Arcade. arcade deploy should be executed at the root of your MCP Server package. Before deploying, the command runs your server locally to ensure your project is setup correctly and the server runs properly. arcade deploy assumes your entrypoint file will execute MCPApp.run when the file is invoked directly. This means you must either have an if __name__ == "__main__" block that contains MCPApp.run, or MCPApp.run` should be top-level code (unindented living directly in the body of the file).

image image

Copy link

vercel bot commented Oct 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
arcade-ai-arcade-mcp-python Ready Ready Preview Comment Oct 13, 2025 3:39am

@EricGustin EricGustin changed the title arcade deploy arcade deploy MCP Servers Oct 13, 2025
@EricGustin EricGustin changed the title arcade deploy MCP Servers arcade deploy for MCP Servers Oct 13, 2025
@EricGustin EricGustin added the component: cli Issues relating to the command line interface label Oct 13, 2025
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reviewing with an eye to DX, and I think there are some minor things we can do to make this a really tight experience.

Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 54.48029% with 127 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
libs/arcade-cli/arcade_cli/deploy.py 54.75% 119 Missing ⚠️
libs/arcade-cli/arcade_cli/main.py 22.22% 7 Missing ⚠️
...ibs/arcade-mcp-server/arcade_mcp_server/mcp_app.py 85.71% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@EricGustin EricGustin requested a review from evantahler October 14, 2025 21:12
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@EricGustin EricGustin merged commit a8fc669 into main Oct 16, 2025
21 of 22 checks passed
@EricGustin EricGustin deleted the ericgustin/deployserver branch October 16, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: cli Issues relating to the command line interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants