-
-
Notifications
You must be signed in to change notification settings - Fork 84
python 3.7 compatibility #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
… a different name
|
When running this with Python 3.8.1, I get this error: Maybe this StackOverflow question can help? |
| self._stderr_reader = asyncio.async(self._read_stderr()) | ||
| self._stdout_reader = asyncio.async(self._read_stdout()) | ||
| _async=getattr(asyncio, 'async') | ||
| self._stderr_reader = _async(self._read_stderr()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the right way to do this is self._stderr_reader = asyncio.ensure_future(self._read_stderr())
|
would be great if something newer than python 3.5 (latest is 3.5.10 released in 2015? 10-year old python at this point) was supported |
This pull request fixes #404
I remembered to:
developand set to merge intodevelopChanges: