-
Notifications
You must be signed in to change notification settings - Fork 7
use pie-documents
#476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
use pie-documents
#476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
This was referenced Jul 19, 2025
…t them from `pie-modules`; fix test_confusion_matrix
…odules; remove empty test file
b9078aa to
2547c7c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
==========================================
- Coverage 78.32% 69.20% -9.13%
==========================================
Files 32 31 -1
Lines 2164 1750 -414
Branches 316 329 +13
==========================================
- Hits 1695 1211 -484
- Misses 378 472 +94
+ Partials 91 67 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Sep 23, 2025
ArneBinder
added a commit
that referenced
this pull request
Sep 23, 2025
that was missed in #476 This also moves the helper method `_config_to_str` to tests package root and fixes an import bug in an *unused* test fixture in tests/taskmodules/test_simple_transformer_text_classification.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
pie-documentsannotationsanddocuments, but re-export them frompie-documentsmetricsandstatistics(exceptTokenCountCollector), but re-export them frompie-documentspandasdependency (was just used in metrics)is_contained_inandhas_overlapfromutils.span, but re-export them frompie-documentsThis requires pie-documents release v0.1.0.
We mark this as breaking, since documents and annotations are now from another package which may cause type mismatches.
IMPORTANT: This will be incompatible with
pie-modules(this is enforced via may pytorch-ie version in latest pie-modules release).