Skip to content

Conversation

@ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Jul 19, 2025

Changes:

  • use pie-documents
  • remove annotations and documents, but re-export them from pie-documents
    • remove respective tests
  • remove metrics and statistics (except TokenCountCollector), but re-export them from pie-documents
    • remove respective tests
    • remove pandas dependency (was just used in metrics)
  • remove is_contained_in and has_overlap from utils.span, but re-export them from pie-documents
    • remove test file with tests that were commented out
  • lower codecov project target from 70% to 68%

This requires pie-documents release v0.1.0.

We mark this as breaking, since documents and annotations are now from another package which may cause type mismatches.

IMPORTANT: This will be incompatible with pie-modules (this is enforced via may pytorch-ie version in latest pie-modules release).

@ArneBinder ArneBinder added the breaking Breaking Changes label Jul 19, 2025
@ArneBinder ArneBinder linked an issue Jul 19, 2025 that may be closed by this pull request
3 tasks
@ArneBinder ArneBinder removed the breaking Breaking Changes label Jul 19, 2025
@ArneBinder ArneBinder added the breaking Breaking Changes label Jul 22, 2025
@ArneBinder ArneBinder changed the title use pie-modules use pie-documents Sep 22, 2025
@ArneBinder ArneBinder marked this pull request as ready for review September 22, 2025 21:37
@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.20%. Comparing base (7bc0040) to head (be37f64).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rch_ie/metrics/statistics/token_count_collector.py 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
- Coverage   78.32%   69.20%   -9.13%     
==========================================
  Files          32       31       -1     
  Lines        2164     1750     -414     
  Branches      316      329      +13     
==========================================
- Hits         1695     1211     -484     
- Misses        378      472      +94     
+ Partials       91       67      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArneBinder ArneBinder self-assigned this Sep 22, 2025
@ArneBinder ArneBinder merged commit 4de30aa into main Sep 23, 2025
4 checks passed
@ArneBinder ArneBinder deleted the use_pie_modules branch September 23, 2025 10:59
ArneBinder added a commit that referenced this pull request Sep 23, 2025
that was missed in #476

This also moves the helper method `_config_to_str` to tests package root
and fixes an import bug in an *unused* test fixture in
tests/taskmodules/test_simple_transformer_text_classification.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking Changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use pie-documents

2 participants