chore: fix wrong float test #2952
Merged
+2,611
−2,296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CountBleck
approved these changes
Oct 14, 2025
Comment on lines
81
to
87
| // always true | ||
| assert(+.0 == -.0); | ||
| assert(-.0 != -.0); | ||
| assert(-.0 == -.0); | ||
| assert(-.0 == +.0); | ||
| assert(f32(+.0) == f32(-.0)); | ||
| assert(f32(-.0) != f32(-.0)); | ||
| assert(f32(-.0) == f32(-.0)); | ||
| assert(f32(-.0) == f32(+.0)); |
There was a problem hiding this comment.
I wonder why this test was written this way...it looks more-or-less intentional(?)
In any case, the correct semantics would be those of JS/Wasm/IEEE-754 anyway.
There was a problem hiding this comment.
The tests actually check the diagnostics and hints of compiler frontend. See: https://github.com/AssemblyScript/assemblyscript/pull/2952/files#diff-dec791c05d5315d6edae920358bc2a389aeed521c38567ddcd5da184a2177d7cR11
There was a problem hiding this comment.
The operator being == instead of != doesn't affect the hints in any way...does it? (If not, should it?)
There was a problem hiding this comment.
Yes. it doesn't matter
> [email protected] asbuild:release
> asc assembly/index.ts --target release
WARNING AS908: Comparison with -0.0 is sign insensitive. Use Object.is(x, -0.0) if the sign matters.
:
1 │ f32(-0.0) != f32(-0.0);
│ ~~~~~~~~~~~~~~~~~~~~~~
└─ in assembly/index.ts(1,1)
WARNING AS908: Comparison with -0.0 is sign insensitive. Use Object.is(x, -0.0) if the sign matters.
:
3 │ f32(-0.0) == f32(-0.0);
│ ~~~~~~~~~~~~~~~~~~~~~~
└─ in assembly/index.ts(3,1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json which has stderr will not check the execution and snopshot.