Skip to content

Conversation

@shmokmt
Copy link
Contributor

@shmokmt shmokmt commented Nov 21, 2024

Description

Ruby on Rails 8.0 is out.
https://edgeguides.rubyonrails.org/8_0_release_notes.html

However, Rails8 requires Ruby 3.2 or higher version and latest jruby version is still Ruby 3.1 compatibility.
Considering these, I excluded fail jobs.
https://github.com/rails/rails/blob/5287cfa17681527761c50fd8c6ae169f4500bd97/rails.gemspec#L12
https://github.com/jruby/jruby/releases/tag/9.4.9.0

Thanks!

@shmokmt shmokmt marked this pull request as ready for review November 21, 2024 11:01
@shmokmt
Copy link
Contributor Author

shmokmt commented Nov 21, 2024

@PikachuEXE
I checked that all tests passed.
shmokmt#1

@PikachuEXE
Copy link
Member

Please help me update all 3.0 to "3.0" to ensure it really test 3.0 (otherwise parsed as 3 = latest 3.x)
Also 3.0 need to be excluded

@shmokmt shmokmt force-pushed the run-tests-on-rails8 branch from 2f15e66 to f1f1545 Compare November 22, 2024 00:34
@shmokmt
Copy link
Contributor Author

shmokmt commented Nov 22, 2024

@PikachuEXE
I fixed.
Could you review again?
f1f1545

All tests passed.
https://github.com/shmokmt/asset_sync/actions/runs/11964151388/job/33355968682

@PikachuEXE PikachuEXE merged commit a1fa197 into AssetSync:master Nov 22, 2024
26 checks passed
@shmokmt shmokmt deleted the run-tests-on-rails8 branch November 22, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants