chore: Remove lockdrop precompile calls #1573
Conversation
ipapandinas
added
shiden
Minimum allowed line rate is |
|
LGTM but please make sure to check with the FE team about the impact. |
|
@ipapandinas @Dinonard precompiles cannot be removed, what happens to existing contracts using it? |
|
I am not comfortable removing this precompile either. I did a quick investigation and found that several lockdrop addresses are still being used. I will not include its removal in the next runtime upgrade. |
| DecodeLimit: Get<u32>, | ||
| { | ||
| #[precompile::public("dispatch_lockdrop_call(bytes,bytes)")] | ||
| fn dispatch_lockdrop_call( |
There was a problem hiding this comment.
@ipapandinas @ermalkaleci related to your concerns, please check this.
This can only be called by EoAs, not smart contracts.
This was added back in 2024 since some accounts continued to use this lockdrop account approach even after it was discontinued. The purpose was for users to claim their lockdrop rewards, and move them to an actual account supported by the Astar/Shiden.
The idea was to remove it after 3 months, but it is still here.
We haven't even documented it, intentionally, since a few users were supposed to get their funds out, and we'd close this backdoor.
There was a problem hiding this comment.
For example, this ETH address participated to the 1st lockdrop and its associated Substrate account still has been active this year and has funds.
There was a problem hiding this comment.
I suggest to take it up with G' then.
The agreement was that we'd take it down before. But everyone seems to have forgotten about it.
Anyways, even if we leave it it's not the end of the world since the whole precompile is quite limited with what user can do.
Checking how many such accounts are left would be beneficial - if there are only a few, perhaps we might know who they are associated with.
# Conflicts: # precompiles/dispatch-lockdrop/Cargo.toml # precompiles/dispatch-lockdrop/src/lib.rs # precompiles/dispatch-lockdrop/src/mock.rs
Pull Request Summary
Closes #1518