Slight rework of PR #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate profiles for common services
alukach
commented
Aug 1, 2025
| environment: | ||
| STAC_FASTAPI_TITLEL: stac-fastapi-opensearch | ||
| STAC_FASTAPI_TITLE: stac-fastapi-opensearch |
There was a problem hiding this comment.
I'm assuming that this was a typo?
jamesfisher-geo
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright, this experience has me questioning if I know how to use Git. I'm not sure what the simplest way is to make changes to your PR from a fork. So, here we are.
developmentseed#71 looks great, thank you so much for adding it!
Profiles
I think using profiles was a very clever and reasonable way to demonstrate support for multiple STAC API backends. However, it's a bit cumbersome when someone wants to quickly just "go", so I think it makes sense to have a default. Seeing as pgSTAC is the current default today, I've moved it to the
''profile, making it operate by default1.Additionally, we can simplify configuration by having both STAC API backends use the same
hostname(i.e.stac).As a final adjustment with regards to profiles, I figure we can just do away with the concept for common services (i.e.
oidcandproxy).Envs
I tried to drop some of the minutia configuration from the STAC services, as the defaults are likely sufficient.
Docs
Did a bit of a cleanup on the docs, imposing more hierarchy to the text.
Footnotes
https://stackoverflow.com/a/77129516 ↩