Skip to content

Conversation

@rccarlson
Copy link

HTML and CSS files were moved to public, which is made available via GitHub Pages.

This also leaves a TODO in the CICD for tests to be implemented later.

Copilot AI review requested due to automatic review settings December 18, 2025 17:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR establishes the foundation for a GitHub Pages deployment by moving HTML and CSS files to a public folder and creating a basic CI/CD pipeline using GitHub Actions. The changes introduce a Leaflet-based interactive map application for displaying locations in downtown Augusta, GA.

  • Creates a public folder structure with HTML and CSS files for GitHub Pages deployment
  • Implements a GitHub Actions workflow with separate test and deploy jobs
  • Sets up an interactive map with multiple tile layer options and custom emoji markers for local businesses

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.

File Description
public/style.css Defines styling for the Leaflet map interface, including custom emoji markers, layer controls, and popups with artistic theme
public/index.html Creates the main map application with Leaflet integration, multiple map tile layers, coordinate picker functionality, and markers for local Augusta businesses
.github/workflows/deploy.yml Establishes CI/CD pipeline with placeholder test job and GitHub Pages deployment configured to run on pushes to main branch

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +10 to +29
test:
name: Run Tests
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4

# TODO: Add test commands here
# Examples:
# - name: Install dependencies
# run: npm install
# - name: Run unit tests
# run: npm test
# - name: Run integration tests
# run: npm run test:integration

deploy:
name: Deploy to GitHub Pages
runs-on: ubuntu-latest
needs: test
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test job has no actual test steps, causing it to succeed immediately without performing any validation. While the TODO comment acknowledges this is planned for later, consider either adding a placeholder test command that fails with a clear message indicating tests need to be implemented, or remove the test job entirely until tests are ready. An always-passing test job can create a false sense of security in the CI/CD pipeline.

Suggested change
test:
name: Run Tests
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
# TODO: Add test commands here
# Examples:
# - name: Install dependencies
# run: npm install
# - name: Run unit tests
# run: npm test
# - name: Run integration tests
# run: npm run test:integration
deploy:
name: Deploy to GitHub Pages
runs-on: ubuntu-latest
needs: test
deploy:
name: Deploy to GitHub Pages
runs-on: ubuntu-latest

Copilot uses AI. Check for mistakes.
@rccarlson
Copy link
Author

image Had to update this setting on my fork. May need to do the same for the build to work properly

@rccarlson
Copy link
Author

Fixes #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants