Skip to content

Commit 3ea97cb

Browse files
committed
chore: remove old TODOs
1 parent b656d4a commit 3ea97cb

File tree

4 files changed

+5
-13
lines changed

4 files changed

+5
-13
lines changed

fission/src/mirabuf/MirabufParser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ class MirabufParser {
389389
private loadGlobalTransforms() {
390390
const root = this._designHierarchyRoot
391391
const parts = this._assembly.data?.parts
392-
if (!parts) return // TODO not sure if we should return or provide a default value
392+
if (!parts) return
393393

394394
const partInstances = new Map<string, mirabuf.IPartInstance>(Object.entries(parts.partInstances!))
395395
const partDefinitions = parts.partDefinitions!

fission/src/ui/modals/configuring/SettingsModal.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,6 @@ const GeneralTab: React.FC<GeneralTabProps> = ({ writePreference }) => (
165165
onClick={checked => {
166166
writePreference("RenderScoreboard", checked)
167167
if (checked) {
168-
// TODO: figure out scoreboard - I think it should be its own component and not a panel
169168
// openPanel("scoreboard");
170169
}
171170
}}

fission/src/ui/modals/mirabuf/ImportLocalMirabufModal.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,9 @@ const ImportLocalMirabufModal: React.FC<ModalImplProps<void, void>> = ({ modal }
5151
World.physicsSystem.holdPause(PAUSE_REF_ASSEMBLY_SPAWNING)
5252
await MirabufCachingService.cacheAndGetLocalWithInfo(hashBuffer, miraType)
5353
.then(x => {
54-
if (x) {
55-
// TODO This function shouldn't cache game pieces when imported locally!!!
56-
return createMirabuf(x.assembly, x.cacheInfo.id, miraType)
57-
}
58-
return undefined
54+
if (!x) return undefined
55+
56+
return createMirabuf(x.assembly, x.cacheInfo.id, miraType)
5957
})
6058
.then(x => {
6159
if (x) {

fission/src/ui/panels/simulation/DriverStationPanel.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,8 @@ const DriverStationPanel: React.FC<PanelImplProps<void, void>> = ({ panel }) =>
99
const [enabled, setEnabled] = useState(false)
1010

1111
useEffect(() => {
12-
// TODO: update Not Connected dynamically when implemented
1312
configureScreen(panel!, { title: "Driver Station (Not Connected)" }, {})
14-
}, [
15-
// TODO: update Not Connected dynamically when implemented
16-
configureScreen,
17-
panel,
18-
])
13+
}, [configureScreen, panel])
1914

2015
return (
2116
<Stack direction="row">

0 commit comments

Comments
 (0)