-
Notifications
You must be signed in to change notification settings - Fork 61
Exporter DRC UI #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Exporter DRC UI #1214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI here doesn't seem as extensible/modifiable in the future as it could be. Ideally adding another rule would be as simple as adding the calculation function, a name, and the max value to an array, rather than require adding new inputs manually
This also isn't necessarily part of this PR because it's mostly for the UI, but I think these calculations are just not correct. My calculated height for this "robot" is about 30cm but it's reporting over 150cm. It also appears to use the bounding box of the robot (not the length of the outermost surface) which causes it to underreport non-rectangles.

Would also probably be nice to allow max values to change from year to year, as they often do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it still has the problem with concave frame perimeters (and also bumpers I suppose) but that's probably out of scope (and also maybe something we just don't deal with). lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Needs updating towards #1194.
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing shows up in the DRC tab when I run this
@@ -299,6 +300,9 @@ def notify(self, html_args: adsk.core.HTMLEventArgs) -> None: | |||
elif html_args.action == "cancelSelection": | |||
gm.ui.terminateActiveCommand() | |||
html_args.returnData = "{}" | |||
|
|||
elif html_args.action == "designRules": | |||
html_args.returnData = DesignRuleChecks().getDesignRules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be dumped as json
8b0a66c
to
0fe4a98
Compare
Task
Adding the ability for users to view whether their robot design meets the guidelines outlined in the FRC inspection checklist.
AARD-1882
Solution
Created an Exporter tab that shows the user the characteristics of their design and cross check them with the FRC Inspection Checklist.
Before merging, ensure the following criteria are met: