Skip to content

Exporter DRC UI #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: dev
Choose a base branch
from
Open

Exporter DRC UI #1214

wants to merge 29 commits into from

Conversation

Dhruv-0-Arora
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora commented Jul 14, 2025

Task

Adding the ability for users to view whether their robot design meets the guidelines outlined in the FRC inspection checklist.

AARD-1882

Solution

Created an Exporter tab that shows the user the characteristics of their design and cross check them with the FRC Inspection Checklist.

Screenshot 2025-07-18 at 3 08 05 PM

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@Dhruv-0-Arora Dhruv-0-Arora marked this pull request as ready for review July 18, 2025 17:41
@Dhruv-0-Arora Dhruv-0-Arora requested review from a team as code owners July 18, 2025 17:41
@Dhruv-0-Arora Dhruv-0-Arora added the ui/ux Relating to user interface, or in general, user experience label Jul 18, 2025
Copy link
Member

@rutmanz rutmanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ImageI like the font on these

The UI here doesn't seem as extensible/modifiable in the future as it could be. Ideally adding another rule would be as simple as adding the calculation function, a name, and the max value to an array, rather than require adding new inputs manually

This also isn't necessarily part of this PR because it's mostly for the UI, but I think these calculations are just not correct. My calculated height for this "robot" is about 30cm but it's reporting over 150cm. It also appears to use the bounding box of the robot (not the length of the outermost surface) which causes it to underreport non-rectangles.

Image

Would also probably be nice to allow max values to change from year to year, as they often do

@Dhruv-0-Arora Dhruv-0-Arora requested a review from rutmanz July 23, 2025 22:45
@rutmanz
Copy link
Member

rutmanz commented Jul 24, 2025

This appears to have made it worse (?). Synthesis and fusion swap the meaning of Y and Z (fusion has XY as the floor, but fission has XZ), and so the meaning of height for a robot that is later imported into synthesis is kind of weird (also the robot levitation appears to be based on the "down" as defined by fusion -Y, so rotating doesn't just fix it)
image

Copy link
Member

@rutmanz rutmanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it still has the problem with concave frame perimeters (and also bumpers I suppose) but that's probably out of scope (and also maybe something we just don't deal with). lgtm

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Needs updating towards #1194.

@rutmanz rutmanz self-requested a review July 28, 2025 16:31
@autodesk-chorus
Copy link

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement.

Copy link
Member

@rutmanz rutmanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing shows up in the DRC tab when I run this

@@ -299,6 +300,9 @@ def notify(self, html_args: adsk.core.HTMLEventArgs) -> None:
elif html_args.action == "cancelSelection":
gm.ui.terminateActiveCommand()
html_args.returnData = "{}"

elif html_args.action == "designRules":
html_args.returnData = DesignRuleChecks().getDesignRules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be dumped as json

@Dhruv-0-Arora Dhruv-0-Arora force-pushed the dhruv/1882/drc-ui-support branch from 8b0a66c to 0fe4a98 Compare August 7, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants