Proper Error Handling When No Grounded Node Found #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azaleacolburn
force-pushed
the
colbura/1995/no-grounded-traceback
branch
from
6f2a8a4 to
e0d9dbd
Compare
BrandonPacewic
requested changes
Jul 30, 2025
rutmanz
requested changes
Jul 31, 2025
| try: | ||
| Parser.Parser(exporterOptions).export() | ||
| except: | ||
| return |
There was a problem hiding this comment.
Yeah I think you should pass errors back to the web ui (using html_args.returnData) to avoid showing a success message
azaleacolburn
force-pushed
the
colbura/1995/no-grounded-traceback
branch
from
bd15709 to
ed338ad
Compare
| @@ -221,7 +222,7 @@ def __init__(self, design: adsk.fusion.Design) -> None: | |||
| self.grounded = searchForGrounded(design.rootComponent) | |||
|
|
|||
| if self.grounded is None: | |||
| message = "These is no grounded component in this assembly, aborting kinematic export." | |||
| message = "There is not a grounded component in this assembly, aborting kinematic export." | |||
There was a problem hiding this comment.
Personally I feel this message is a bit unclear. Something I believe would help the user more would be to add "Please pin a component."
exporter/SynthesisFusionAddin/src/Parser/SynthesisParser/JointHierarchy.py
Outdated
Show resolved
Hide resolved
…Hierarchy.py Co-authored-by: Dhruv Arora <[email protected]>
rutmanz
requested changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
AARD-1995
Symptom
When exporting is aborted due to there being no grounded node in the assembly (usually because there is no assembly), a traceback appeared and the progress dialogue did not close automatically.
Solution
When the
buildJointPartHierarchyfunction catches the raised error fromJointParser.__init__, it hides the progress dialogue then calls raises another error to abort parsing. Additionally, when runtime exceptions are caught fromParser.export()in bothConfigCommand.export()(new UI) andnotify()(old UI), the parent function returns instead of passing, aborting the export.Verification
Export a blank assembly, observe that no file is saved, the progress dialogue is closed, and no traceback is displayed.
Before merging, ensure the following criteria are met: