Skip to content

Add Robot Spawn Positions [AARD-2041] #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Conversation

rutmanz
Copy link
Member

@rutmanz rutmanz commented Aug 4, 2025

Task

AARD-2041

Symptom

Currently robots spawn at the center of the field (2018 is particularly annoying here) and have no defined starting places for match mode. This means that they will start wherever they were last sitting before match mode started, which isn't necessarily what you want

This will be particularly important for multiplayer games where you have several robots to deal with

Solution

Adds default spawn positions for each driver station to the devtools interface and allows them to be configured through there. I have configured default positions for the 2018 field and updated the assetpack
image

Verification

  1. Run bun assetpack
  2. Spawn 2018 field v13
  3. Spawn Dozer (and notice that it isn't inside a wall)
  4. Start match mode and check the "Move Robots to Starting Positions" checkbox
  5. Observe how your robot moved to that spot

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@rutmanz rutmanz self-assigned this Aug 4, 2025
@rutmanz rutmanz added the gameplay Relating to the playability of Synthesis label Aug 4, 2025
@rutmanz rutmanz requested review from a team as code owners August 4, 2025 19:49
@rutmanz rutmanz requested a review from azaleacolburn August 5, 2025 18:58
@ryanzhangofficial
Copy link
Member

When I spawn two 2024 kitbots and 2024 field and start matchmode with the toggle on and different driver stations, they both snap to the center of the field and are on top of each other.

@rutmanz rutmanz marked this pull request as draft August 6, 2025 18:23
@rutmanz
Copy link
Member Author

rutmanz commented Aug 6, 2025

@ryanzhangofficial This is because that field doesn't have actual points configured (I've only done 2018), but I changed the defaults so that they won't overlap anymore

I can create default spawn points for all of the fields but it might make more sense as a separate ticket (thoughts?)

@rutmanz rutmanz requested a review from BrandonPacewic August 6, 2025 18:53
@rutmanz rutmanz marked this pull request as ready for review August 6, 2025 18:53
Copy link
Member

@AlexD717 AlexD717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Can this new FRC field be added to where our current fields are hosted?

@ryanzhangofficial
Copy link
Member

@ryanzhangofficial This is because that field doesn't have actual points configured (I've only done 2018), but I changed the defaults so that they won't overlap anymore

I can create default spawn points for all of the fields but it might make more sense as a separate ticket (thoughts?)

I think that would be helpful. What happens if a user imports a custom mira field file though? It would be confusing to still have the toggle if the functionality isn't there.

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small conflicts from #1251 but otherwise looks good.

@rutmanz rutmanz requested a review from BrandonPacewic August 11, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gameplay Relating to the playability of Synthesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants