Skip to content

Conversation

@EliNedyalkova
Copy link
Collaborator

No description provided.

@EliNedyalkova EliNedyalkova requested a review from n1xan July 25, 2025 07:57
import java.util.Collection;

public class TestDataFacade {
@Deprecated(since = "Use MapperUtility instead of this field.", forRemoval = true)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can update this and remove the depricated tag


import java.lang.reflect.Type;

public class CustomGsonObjectMapperFactory implements GsonObjectMapperFactory {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be needed with the Data module - check if you can remove it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

public class CurlLoggingFilter implements Filter {

@Override
public Response filter(FilterableRequestSpecification requestSpec, FilterableResponseSpecification responseSpec, FilterContext ctx) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if this is added to the data module. It will be useful there


import static com.google.gson.FieldNamingPolicy.LOWER_CASE_WITH_UNDERSCORES;

public class EntityDeleterRepository {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is htis using the data module?

import static com.google.gson.FieldNamingPolicy.LOWER_CASE_WITH_UNDERSCORES;

@SuppressWarnings("UnnecessaryLocalVariable")
public abstract class HttpRepository<TEntity extends ApiEntity, TEntities extends Entities<TEntity>> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also be part of the data module - remove if not needed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

import java.util.List;

@SuppressWarnings("UnnecessaryLocalVariable")
public abstract class TableApiRepository<TEntity extends ApiEntity, TEntities extends Entities<TEntity>> extends HttpRepository<TEntity, TEntities> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the old class TableApiRepository updated using data module

return typeAdapters;
}

public static LinkedHashMap<Type, Object> allExceptEntities() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be added to the data module

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new typeAdapters package added

public class RepositoriesMap {
public static Map<Class<? extends ApiEntity>, Class<? extends TableApiRepository<?, ?>>> realEstateRepos() {
var map = new HashMap<Class<? extends ApiEntity>, Class<? extends TableApiRepository<?, ?>>>();
// The following Code Will be used when need to use MassiveDataDeleter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all commented repos and chech the whole project for left over project code

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not be used with the new TableApiRepository setup.


import static org.junit.jupiter.api.Assertions.assertTrue;

public class ServiceNowPage extends WebPage<Map, Asserts> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the package to match the page name

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed




public class ServiceNowTableViewPage extends WebPage<Map, Asserts> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the package name to match the class

}
]
},
"serviceNowProjectSettings": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove on a commit and keep the read data checked out only locally

EliNedyalkova added 3 commits August 7, 2025 15:41
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
@EliNedyalkova EliNedyalkova changed the base branch from feature/service-now-module to main August 8, 2025 10:29
EliNedyalkova added 6 commits August 8, 2025 13:35
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
@n1xan n1xan self-requested a review August 12, 2025 11:02
@EliNedyalkova EliNedyalkova merged commit c5271d7 into main Aug 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants