-
Notifications
You must be signed in to change notification settings - Fork 12
Feature/service now module initial setup #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/service now module initial setup #77
Conversation
getting-started/bellatrix.servicenow.getting.started/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...bellatrix.servicenow.getting.started/src/main/resources/testFrameworkSettings.dev329858.json
Show resolved
Hide resolved
getting-started/bellatrix.servicenow.getting.started/src/test/java/O1_Login/readme.txt
Outdated
Show resolved
Hide resolved
getting-started/bellatrix.servicenow.getting.started/src/test/java/O1_Login/readme.txt
Outdated
Show resolved
Hide resolved
getting-started/bellatrix.servicenow.getting.started/src/test/java/O1_Login/readme.txt
Outdated
Show resolved
Hide resolved
getting-started/bellatrix.servicenow.getting.started/src/test/java/O1_Login/readme.txt
Outdated
Show resolved
Hide resolved
...ed/bellatrix.servicenow.getting.started/src/test/java/O4_TableView/data/ReservationForm.java
Outdated
Show resolved
Hide resolved
| import java.util.Collection; | ||
|
|
||
| public class TestDataFacade { | ||
| @Deprecated(since = "Use MapperUtility instead of this field.", forRemoval = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can update this and remove the depricated tag
|
|
||
| import java.lang.reflect.Type; | ||
|
|
||
| public class CustomGsonObjectMapperFactory implements GsonObjectMapperFactory { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be needed with the Data module - check if you can remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
| public class CurlLoggingFilter implements Filter { | ||
|
|
||
| @Override | ||
| public Response filter(FilterableRequestSpecification requestSpec, FilterableResponseSpecification responseSpec, FilterContext ctx) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check if this is added to the data module. It will be useful there
|
|
||
| import static com.google.gson.FieldNamingPolicy.LOWER_CASE_WITH_UNDERSCORES; | ||
|
|
||
| public class EntityDeleterRepository { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is htis using the data module?
| import static com.google.gson.FieldNamingPolicy.LOWER_CASE_WITH_UNDERSCORES; | ||
|
|
||
| @SuppressWarnings("UnnecessaryLocalVariable") | ||
| public abstract class HttpRepository<TEntity extends ApiEntity, TEntities extends Entities<TEntity>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should also be part of the data module - remove if not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
| import java.util.List; | ||
|
|
||
| @SuppressWarnings("UnnecessaryLocalVariable") | ||
| public abstract class TableApiRepository<TEntity extends ApiEntity, TEntities extends Entities<TEntity>> extends HttpRepository<TEntity, TEntities> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the old class TableApiRepository updated using data module
| return typeAdapters; | ||
| } | ||
|
|
||
| public static LinkedHashMap<Type, Object> allExceptEntities() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these should be added to the data module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new typeAdapters package added
| public class RepositoriesMap { | ||
| public static Map<Class<? extends ApiEntity>, Class<? extends TableApiRepository<?, ?>>> realEstateRepos() { | ||
| var map = new HashMap<Class<? extends ApiEntity>, Class<? extends TableApiRepository<?, ?>>>(); | ||
| // The following Code Will be used when need to use MassiveDataDeleter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove all commented repos and chech the whole project for left over project code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can not be used with the new TableApiRepository setup.
|
|
||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| public class ServiceNowPage extends WebPage<Map, Asserts> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename the package to match the page name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed
|
|
||
|
|
||
|
|
||
| public class ServiceNowTableViewPage extends WebPage<Map, Asserts> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update the package name to match the class
| } | ||
| ] | ||
| }, | ||
| "serviceNowProjectSettings": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove on a commit and keep the read data checked out only locally
# Conflicts: # pom.xml
update getting-started\bellatrix.servicenow
…dule-initial-setup
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
update getting-started\bellatrix.servicenow
No description provided.