Skip to content

Conversation

dhasilva
Copy link
Contributor

Follow-up to #44118
Part of FORMS-69

Proposed changes:

  • Refactors the process_submission function to be able to return a JSON value early, leaving post-save processing like sending emails to a scheduled event

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1751001430519649/1750983995.755359-slack-C052XEUUBL4

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Make sure the feature flag is disabled
  • Submit a form on a site that sends emails on form submission
  • Check that there are no regressions. Emails are sent as normal and data is persisted as it has been so far.
  • Enable the feature flag
  • Reload the form page and submit it again
  • Check that the JSON is returned on the network tab (it is not updated on the frontend at this point)
  • Check that you receive the email
  • Other than the lack of a page refresh with the submission data, everything else should remain exactly as it was before, so the submission should be in the dashboard as well

@dhasilva dhasilva requested a review from a team June 28, 2025 00:09
@dhasilva dhasilva self-assigned this Jun 28, 2025
@dhasilva dhasilva added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. labels Jun 28, 2025
Copy link
Contributor

github-actions bot commented Jun 28, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-submit-ajax-json-async branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-submit-ajax-json-async

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/class-jetpack-forms.php 6/19 (31.58%) -1.75% 1 ❤️‍🩹
projects/packages/forms/src/contact-form/class-contact-form.php 611/1041 (58.69%) 1.21% 1 ❤️‍🩹

Full summary · PHP report · JS report

@dhasilva dhasilva closed this Jul 10, 2025
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Contact Form [Package] Forms [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant