Skip to content

Conversation

tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Jul 3, 2025

This disables the generation of sourcemap files.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

@tbradsha tbradsha requested a review from mikestottuk July 3, 2025 20:26
@tbradsha tbradsha self-assigned this Jul 3, 2025
@tbradsha tbradsha added [Type] Janitorial [Status] Needs Review This PR is ready for review. labels Jul 3, 2025
@github-actions github-actions bot added the [Plugin] CRM Issues about the Jetpack CRM plugin label Jul 3, 2025
Copy link
Contributor

github-actions bot commented Jul 3, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

Copy link
Contributor

@mikestottuk mikestottuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tbradsha tbradsha merged commit 180b770 into trunk Jul 7, 2025
66 of 67 checks passed
@tbradsha tbradsha deleted the fix/crm/disable_sourcemap_generation branch July 7, 2025 13:39
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] CRM Issues about the Jetpack CRM plugin [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants