Skip to content

Boost: Exclude scripts of type module from concatenation #44193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dilirity merged 7 commits into from
Jul 8, 2025
Merged

Boost: Exclude scripts of type module from concatenation #44193

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8b4d259
Update concat JS to skip scripts of type module
dilirity Jul 4, 2025
80cec0f
add changelog
dilirity Jul 4, 2025
aef3718
Fix stripping script type from modules
dilirity Jul 7, 2025
6a7afe7
Simplify check
dilirity Jul 8, 2025
b6625f7
Use WP_HTML_Tag_Processor instead of regex to get script type
dilirity Jul 8, 2025
68edece
Update script type helper to always return either type or false on fail
dilirity Jul 8, 2025
18d16e4
Simplify check
dilirity Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions projects/plugins/boost/app/lib/minify/class-concatenate-js.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,20 @@ public function do_items( $handles = false, $group = false ) {
}
}

// This is a workaround to get the type of the script without outputting it.
// Build the final version of the script tag (by running it through apply_filters)
// and then checking the type. If it's a module script,
// skip it, as modules can't be concatenated with other scripts.
$script_tag = '<script type="text/javascript" src="' . esc_url( $js_url ) . '"></script>';
$script_tag = apply_filters( 'script_loader_tag', $script_tag, $handle, $js_url );
$script_type = preg_match( '/<script type=(["\'])([^"\']+)\1/', $script_tag, $matches ) ? $matches[2] : 'text/javascript';
if ( 'module' === $script_type ) {
$do_concat = false;
if ( defined( 'WP_DEBUG' ) && WP_DEBUG ) {
printf( "\n<!-- No Concat JS %s => Module Script -->\n", esc_html( $handle ) );
}
}

/**
* Filter that allows plugins to disable concatenation of certain scripts.
*
Expand Down
4 changes: 4 additions & 0 deletions projects/plugins/boost/changelog/fix-boost-concat-js-skip-modules-HOG-153
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Concatenate JS: Exclude scripts of type module from concatenation.
Loading