Skip to content

SAL_Site: Prevent warnings due to reading properties on null #44195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025
Merged

SAL_Site: Prevent warnings due to reading properties on null #44195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab69e1e
Prevent warnings due to reading properties on null
coder-karen Jul 4, 2025
651b65f
changelog
coder-karen Jul 4, 2025
4adf206
Check if authorized is true before additional checks
coder-karen Jul 7, 2025
f1a600a
Update projects/plugins/jetpack/sal/class.json-api-site-base.php
coder-karen Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/update-class-json-api-site-base-prevent-prop-warnings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: other

SAL: Ensurethat we don't check for properties on null.
25 changes: 14 additions & 11 deletions projects/plugins/jetpack/sal/class.json-api-site-base.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,21 +770,24 @@ private function user_can_view_post( $post ) {
// If the post is of status inherit, check if the parent exists ( different to 0 ) to check for the parent status object.
if ( 'inherit' === $post->post_status && 0 !== (int) $post->post_parent ) {
$parent_post = get_post( $post->post_parent );
$post_status_obj = get_post_status_object( $parent_post->post_status );
$post_status_obj = $parent_post ? get_post_status_object( $parent_post->post_status ) : null;
} else {
$post_status_obj = get_post_status_object( $post->post_status );
}

$authorized = (
$post_status_obj->public ||
( is_user_logged_in() &&
(
( $post_status_obj->protected && current_user_can( 'edit_post', $post->ID ) ) ||
( $post_status_obj->private && current_user_can( 'read_post', $post->ID ) ) ||
( 'trash' === $post->post_status && current_user_can( 'edit_post', $post->ID ) ) ||
'auto-draft' === $post->post_status
)
)
$authorized = false;

if ( $post_status_obj ) {
$authorized = $post_status_obj->public
|| ( is_user_logged_in() && (
( $post_status_obj->protected && current_user_can( 'edit_post', $post->ID ) )
|| ( $post_status_obj->private && current_user_can( 'read_post', $post->ID ) )
) );
}

$authorized = $authorized || (
( 'trash' === $post->post_status && current_user_can( 'edit_post', $post->ID ) )
|| 'auto-draft' === $post->post_status
);

if ( ! $authorized ) {
Expand Down
Loading