-
Notifications
You must be signed in to change notification settings - Fork 843
Forms: Add backend MailPoet integration #44439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 3 files.
1 file is newly checked for coverage.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
2dfca0c to
f97ce7d
Compare
0d1e6e2 to
f344c08
Compare
dhasilva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works as described
projects/packages/forms/src/contact-form/class-contact-form-plugin.php
Outdated
Show resolved
Hide resolved
projects/packages/forms/src/service/class-mailpoet-integration.php
Outdated
Show resolved
Hide resolved
|
It would be good to wait for #44121 to land since then we could make sure that you can work the the fields easier. |
f344c08 to
3b9a0ec
Compare
b23d67a to
7f0fc47
Compare
|
Update: I hadn't wrapped the hook for the MailPoet logic in the feature flag. This has now been added. So if feature flag is off, no backend MailPoet logic will run (except that connectMailPoet will be added as a new default attribute). |
Fixes FORMS-232
Proposed changes:
Important:
Changes:
MailPoet_Integrationclass to handle MailPoet logic.Jetpack Form Subscriberslist if one does not already exist. The method for this allow allows us to pass in a field name. In a future PR, we should fetch all lists and allow users to select one or add a new list in the block editor in the MailPoet card. I'd like to handle that separately.Follow ups (not yet done):
Other information:
Jetpack product discussion
See the linear issue and project above.
Does this pull request change what data or activity we track or use?
Yes.
Testing instructions: