Skip to content

Conversation

simison
Copy link
Member

@simison simison commented Aug 19, 2025

Add new Activity log module, enabled by default on jetpack connection, and wrap sidebar navigation links with a check if module is enabled.

Screenshot 2025-08-19 at 11 56 08

See convo for more context p1755588858887129-slack-C0D96691V

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Install new jetpack (e.g. Jurassic ninja)
  • Connect jetpack, and see activity log sidebar item gets enabled since module got auto-activated
  • Go my jetpack
  • Disabled AL module
  • Sidebar item is gone

Copy link
Contributor

Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete.

@github-actions github-actions bot added [mu wpcom Feature] Wpcom Admin Menu [Package] Jetpack mu wpcom WordPress.com Features [Package] My Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Aug 19, 2025
Copy link
Contributor

github-actions bot commented Aug 19, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: September 2, 2025
    • Code freeze: September 1, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Aug 19, 2025
Copy link

jp-launch-control bot commented Aug 19, 2025

Code Coverage Summary

Coverage changed in 4 files.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/modules/module-headings.php 210/1022 (20.55%) -0.05% 18 💔
projects/packages/my-jetpack/src/class-activitylog.php 3/19 (15.79%) -1.86% 2 ❤️‍🩹
projects/plugins/jetpack/modules/module-info.php 227/330 (68.79%) -0.23% 2 ❤️‍🩹
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-menu/wpcom-admin-menu.php 0/418 (0.00%) 0.00% 1 ❤️‍🩹

1 file is newly checked for coverage.

File Coverage
projects/plugins/jetpack/modules/activity-log.php 0/0 (—%) 🤷

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@simison simison requested a review from a team August 19, 2025 09:00
@simison simison added [Feature] Activity Log [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Aug 19, 2025
@simison simison requested a review from keoshi August 19, 2025 09:02
@github-actions github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Aug 19, 2025
Copy link
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@keoshi
Copy link
Contributor

keoshi commented Aug 19, 2025

From Slack p1755595722915179/1755588858.887129-slack-C0D96691V

Isn't the module approach a bit misleading. When you disable it, your activity still gets logged

In my opinion, until we can actually avoid syncing all activity this module shouldn't be optional or surfaced.

@simison
Copy link
Member Author

simison commented Aug 19, 2025

until we can actually avoid syncing all activity this

I'm not sure we can or should actually do that? There's lot that we sync for heaps of other reasons, and AL is just UI to see it, while the synced content is used for other those things in first place. I could be missing some angle tho. :-)

@keoshi
Copy link
Contributor

keoshi commented Aug 19, 2025

I'm not sure we can or should actually do that?

@simison Exactly my point. Why would we want to add options to show/hide a UI element when it's only a surface thing? The underlying syncing is still happening, so providing a UI to turn the AL off could make it seem like all syncing activity ceases.

Plus, all we're doing right now is adding a sidebar menu, so having a module activation/deactivation seems a bit much for the value we provide. As mentioned in the Slack convo, the Activity Log could be a MyJP module, similar to what we’re adding to the Hosting Dashboard. Once/if that happens, this control for it seems to make more sense.

@simison
Copy link
Member Author

simison commented Aug 19, 2025

Plus, all we're doing right now is adding a sidebar menu, so having a module activation/deactivation seems a bit much for the value we provide. As mentioned in the Slack convo, the Activity Log could be a MyJP module, similar to what we’re adding to the Hosting Dashboard. Once/if that happens, this control for it seems to make more sense.

I'm also looking at removing the sidebar link in Jetpack Cloud, as well as all the visible upsells/banners related to Activity log based on the module, but I haven't found any backend functionality in Jetpack itself to hide since Activity log all "happens" in our servers.

That's the point from the user perspective — who could for example be an agency — they see a feature they or their customer doesn't need and use, and they can switch a toggle, and they don't see it anymore. Less noise and bloat.

@simison simison closed this Sep 2, 2025
@simison simison deleted the update/add-activity-log-module branch September 2, 2025 12:05
@simison
Copy link
Member Author

simison commented Sep 2, 2025

Closing as stalled.

@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Activity Log [mu wpcom Feature] Wpcom Admin Menu [Package] Jetpack mu wpcom WordPress.com Features [Package] My Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants