-
Notifications
You must be signed in to change notification settings - Fork 834
Modules: add activity log module and wrap navigation link with module check #44839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete. |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 4 files.
1 file is newly checked for coverage.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected.
From Slack p1755595722915179/1755588858.887129-slack-C0D96691V
In my opinion, until we can actually avoid syncing all activity this module shouldn't be optional or surfaced. |
I'm not sure we can or should actually do that? There's lot that we sync for heaps of other reasons, and AL is just UI to see it, while the synced content is used for other those things in first place. I could be missing some angle tho. :-) |
@simison Exactly my point. Why would we want to add options to show/hide a UI element when it's only a surface thing? The underlying syncing is still happening, so providing a UI to turn the AL off could make it seem like all syncing activity ceases. Plus, all we're doing right now is adding a sidebar menu, so having a module activation/deactivation seems a bit much for the value we provide. As mentioned in the Slack convo, the Activity Log could be a MyJP module, similar to what we’re adding to the Hosting Dashboard. Once/if that happens, this control for it seems to make more sense. |
I'm also looking at removing the sidebar link in Jetpack Cloud, as well as all the visible upsells/banners related to Activity log based on the module, but I haven't found any backend functionality in Jetpack itself to hide since Activity log all "happens" in our servers. That's the point from the user perspective — who could for example be an agency — they see a feature they or their customer doesn't need and use, and they can switch a toggle, and they don't see it anymore. Less noise and bloat. |
Closing as stalled. |
Add new Activity log module, enabled by default on jetpack connection, and wrap sidebar navigation links with a check if module is enabled.
See convo for more context p1755588858887129-slack-C0D96691V
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: