Skip to content

Conversation

eoigal
Copy link
Contributor

@eoigal eoigal commented Aug 22, 2025

Add MCP (Model Context Protocol) settings to the site settings endpoint.

Proposed changes:

  • Added mcp_abilities field to site settings API (GET/POST support)
  • Includes MCP enabled toggle and per-ability configuration
  • Added test coverage for new functionality

Structure:

{
  "mcp_abilities": {
    "ability-name": {
      "name": "...",
      "description": "...", 
      "category":"...",
      "type":"...",
      "enabled": true/false
    }
  }
}

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Tests included
  • Go to https://developer.wordpress.com/docs/api/console/
  • Apply JP PR to WPCOM sandbox with bin/jetpack-downloader test jetpack add/mcp-settings
  • Sandbox public-api.wordpress.com
  • Enter GET /sites/$site/settings for a test site, confirm you see settings below
Screenshot 2025-09-01 at 14 46 16

@github-actions github-actions bot added [Feature] WPCOM API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Aug 22, 2025
Copy link
Contributor

github-actions bot commented Aug 22, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Aug 22, 2025
Copy link
Contributor

github-actions bot commented Aug 22, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/mcp-settings branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/mcp-settings

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link

jp-launch-control bot commented Aug 22, 2025

Code Coverage Summary

Coverage changed in 3 files.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/json-endpoints/class.wpcom-json-api-site-settings-endpoint.php 388/845 (45.92%) 2.88% 11 💔
projects/plugins/jetpack/json-endpoints/class.wpcom-json-api-site-settings-v1-4-endpoint.php 0/167 (0.00%) 0.00% 1 ❤️‍🩹
projects/plugins/jetpack/class.json-api.php 43/474 (9.07%) 1.69% -8 💚

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@eoigal eoigal changed the title Add/mcp settings Add MCP (Model Context Protocol) settings to site settings endpoint Aug 27, 2025
@eoigal eoigal changed the title Add MCP (Model Context Protocol) settings to site settings endpoint Add MCP settings to site settings endpoint Aug 27, 2025
@eoigal eoigal added [Status] Needs Review This PR is ready for review. I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Type] Feature Development of a new feature and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Aug 27, 2025
@github-actions github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Aug 27, 2025
@tbradsha
Copy link
Contributor

@eoigal Note that I added wp_get_abilities() stubs from WP.com in #44976, so no need to suppress them in Phan anymore.

@eoigal
Copy link
Contributor Author

eoigal commented Sep 1, 2025

Will add stubs for new AbilityRegistry functions in a follow up p1756730969998889-slack-CDLH4C1UZ

191683-ghe-Automattic/wpcom

@eoigal eoigal added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Sep 1, 2025
@eoigal eoigal merged commit fd15782 into trunk Sep 2, 2025
71 checks passed
@eoigal eoigal deleted the add/mcp-settings branch September 2, 2025 08:45
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Sep 2, 2025
@eoigal eoigal mentioned this pull request Sep 3, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] WPCOM API I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests [Type] Feature Development of a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants