Skip to content

Conversation

adimoldovan
Copy link
Member

@adimoldovan adimoldovan commented Aug 26, 2025

Proposed changes:

Refactored tunnel management scripts by consolidating Cloudflare and LocalTunnel logic into a unified TunnelManager structure.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • e2e tests pass in CI

Locally, run both tunnel options and ensure they work:

pnpm tunnel:up
pnpm tunnel:down
pnpm tunnel:reset


USE_CLOUDFLARE_TUNNEL=1 pnpm tunnel:up
USE_CLOUDFLARE_TUNNEL=1 pnpm tunnel:down
USE_CLOUDFLARE_TUNNEL=1 pnpm tunnel:reset

Copy link
Contributor

github-actions bot commented Aug 26, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Aug 26, 2025
@adimoldovan adimoldovan self-assigned this Aug 26, 2025
@github-actions github-actions bot added the Docs label Aug 26, 2025
@adimoldovan adimoldovan added [Type] Task and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Aug 27, 2025
@adimoldovan adimoldovan marked this pull request as ready for review August 28, 2025 11:14
@adimoldovan adimoldovan merged commit 5a5c956 into trunk Aug 28, 2025
113 of 114 checks passed
@adimoldovan adimoldovan deleted the e2e/merge-tunnel-manager-scripts branch August 28, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant