Skip to content

Conversation

chihsuan
Copy link
Member

@chihsuan chihsuan commented Aug 27, 2025

Proposed changes:

Problem:

The woocommerceanalytics_product_purchase event is currently triggered every time a user refreshes the order confirmation page, due to its reliance on the woocommerce_thankyou hook. This causes duplicate events, which is problematic, especially when users open the order confirmation page in another device/browser since we use this event to track completed checkouts and calculate conversion rates accurately.

Solution:

This update resolves the issue by switching from the woocommerce_thankyou hook to the woocommerce_checkout_order_processed and woocommerce_store_api_checkout_order_processed hooks. These order processed hooks are triggered only once when the order is completed, ensuring the event is not duplicated on page refreshes.

Additionally, I have modified the capture_event_in_session_data method to accept event properties and to standardize the order of its parameters.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Does this pull request change what data or activity we track or use?

No, this PR does not change what data we track. It only fixes the timing and frequency of when the existing woocommerceanalytics_product_purchase events are triggered to prevent duplicates.

Testing instructions:

  • Set up a WooCommerce store with Jetpack WooCommerce Analytics enabled
  • In your WooCommerce admin, set up store so it's ready to accept orders
  • Open your browser’s developer tools and go to the "Network" tab.
  • Add products to cart and complete a purchase
  • After completing the purchase, verify that the woocommerceanalytics_product_purchase event is recorded in the Network tab
  • Refresh the order confirmation/thank you page multiple times
  • Verify that woocommerceanalytics_product_purchase events are not recorded when refreshing the page

Note: You can also check the ClickHouse table to verify that the event is not recorded more than once.

Screenshot 2025-08-27 at 14 38 05

…ooks and improve capture_event_in_session_data method to accept event properties.

This enhances the accuracy of event data captured during checkout and cart actions.
@chihsuan chihsuan changed the title WooCommerce Analytics: Fix duplicate product purchase events on order confirmation page refresh WooCommerce Analytics: Fix duplicate product purchase events Aug 27, 2025
@chihsuan chihsuan self-assigned this Aug 27, 2025
Copy link
Contributor

github-actions bot commented Aug 27, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/woo-analytics-product-purchase-event branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/woo-analytics-product-purchase-event

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Aug 27, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Aug 27, 2025
Copy link

jp-launch-control bot commented Aug 27, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/woocommerce-analytics/src/class-universal.php 0/365 (0.00%) 0.00% 10 💔

Full summary · PHP report · JS report

Coverage check overridden by Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR .

@chihsuan chihsuan added [Status] Needs Review This PR is ready for review. [Type] Task and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Aug 27, 2025
@chihsuan chihsuan requested review from louwie17 and a team August 27, 2025 06:54
add_action( 'woocommerce_thankyou', array( $this, 'order_process' ), 10, 1 );
// order processed.
add_action( 'woocommerce_checkout_order_processed', array( $this, 'order_process' ), 10, 1 );
add_action( 'woocommerce_store_api_checkout_order_processed', array( $this, 'order_process' ), 10, 1 );
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 👍

@kangzj kangzj added the Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR label Aug 28, 2025
@chihsuan chihsuan merged commit b4309d2 into trunk Aug 28, 2025
78 checks passed
@chihsuan chihsuan deleted the fix/woo-analytics-product-purchase-event branch August 28, 2025 06:31
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR [Feature] WooCommerce Analytics [Package] WooCommerce Analytics Enhanced analytics for WooCommerce users [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants