Skip to content

Conversation

tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Aug 27, 2025

Closes MONOREP-86

This changes our use from MailDev to Mailpit.

Both are comparable, and few devs will use most of their capabilities beyond receiving email. In the end the biggest factor for me was size: Mailpit is almost 1/4 the compressed size, which makes for a quicker pull, particularly on slow connections.

Bonus:

  • Two ENV vars in the Dockerfile were updated to use the modern key=value format instead of key value, which removes two deprecation notices.
  • A new PORT_PHPMY var was added to allow people to configure the phpMyAdmin port.
  • PORT_MAILDEV was updated to PORT_INBOX to make it generic. It's unlikely many (if any) use this, so rather than implementing a fallback that handles both, I just directly renamed it.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Check out the PR.
  2. jetpack docker build-image
  3. Verify http://localhost:1080/ loads
  4. Do a password reset on some WP user and verify the email comes through.

@tbradsha tbradsha requested a review from a team August 27, 2025 19:30
@tbradsha tbradsha self-assigned this Aug 27, 2025
@tbradsha tbradsha added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Aug 27, 2025
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me

@tbradsha
Copy link
Contributor Author

tbradsha commented Sep 4, 2025

Thanks for the review. I'll merge this once I've got a post ready.

@tbradsha tbradsha added the DO NOT MERGE don't merge it! label Sep 4, 2025
@tbradsha tbradsha merged commit 9af7d46 into trunk Sep 9, 2025
97 checks passed
@tbradsha tbradsha deleted the change/docker/maildev_to_mailpit branch September 9, 2025 16:00
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants