Skip to content

Fix: Markdown preview renders hanging indents as code blocks #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Draft

Fix: Markdown preview renders hanging indents as code blocks #3217

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d509028
update some showdown options and try a naive way of fixing indented p…
codebykat Jun 13, 2024
04c6913
experiment with editor options for tab size
codebykat Jun 13, 2024
129ef7c
Revert "experiment with editor options for tab size"
codebykat Jun 13, 2024
d707f80
remove code that is in #3216
codebykat Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/utils/render-note-to-html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,21 @@ export const renderNoteToHtml = (content: string) => {
markdownConverter.setOption('tables', true); // table syntax
markdownConverter.setOption('strikethrough', true); // ~~strikethrough~~

const transformedContent = content.replace(
let transformedContent = content.replace(
/([ \t\u2000-\u200a]*)\u2022(\s)/gm,
'$1-$2'
); // normalized bullets

// remove tab indentation on paragraphs
// TODO this is very naive and fragile and will break in a lot of cases, such as:
// - different size indentations
// - paragraphs that begin with a number or a list character
// - list characters other than - and *
transformedContent = content.replace(
/\n {4}(([^-*\d]))/g,
'\n   $1'
);

return sanitizeHtml(markdownConverter.makeHtml(transformedContent));
}
);
Expand Down