-
Notifications
You must be signed in to change notification settings - Fork 50
Migrate release uploads to Apps CDN #1422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Purpose: Migrate release uploads to Apps CDN by updating CDN URLs and related tooling.
- Update CDN URLs in the release manifest generation script.
- Update documentation to reference the correct manifest script filename.
- Upgrade the fastlane-plugin-wpmreleasetoolkit gem to version 13.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
scripts/generate-releases-manifest.mjs | Updated CDN URLs to point to Apps CDN. |
docs/versioning-and-updates.md | Adjusted script filename reference in documentation. |
Gemfile | Upgraded fastlane-plugin-wpmreleasetoolkit to v13. |
…e `cdn_url` added dynamically
We shouldn't merge this PR until STU-707 is solved. |
📊 Performance Test ResultsComparing 5f78b6a vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
Related issues
Proposed Changes
Testing Instructions
Make sure you have all the build files in the
out
folder. You can download them from buildkite.DRY_RUN=true BUILDKITE_BUILD_NUMBER=9999 bundle exec fastlane distribute_dev_build
Check the file_paths point to existing files.
Upload files to Apps CDN
You can grab the WPCOM_API_TOKEN from the secret store.
WPCOM_API_TOKEN=12546 BUILDKITE_BUILD_NUMBER=1338 bundle exec fastlane distribute_dev_build
https://appscdn.wordpress.com/products/wordpress-com-studio/
Confirm the https://appscdn.wordpress.com/builds/wordpress-com-studio/releases.json include the correct versions.
To see the valid parameters that
upload_build_to_apps_cdn
accepts, you can execute:bundle exec fastlane action upload_build_to_apps_cdn
Pre-merge Checklist