Fix: Gradient overlay on tables does not disappear on resize #10970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +222 B (0%) Total Size: 869 kB
ℹ️ View Unchanged
|
…does-not-disappear-on-resize
mgascam
changed the title
frosso
reviewed
Jul 30, 2025
There was a problem hiding this comment.
I think the solution works for us, but since this is a WC Core component, shouldn't the fix lie in the Table component we consume from WC Core? It seems that the calculation that adds the is-scrollable-right class isn't working correctly.
What seems to be happening to me is that this useEffect in WC Core ( https://github.com/woocommerce/woocommerce/blob/trunk/packages/js/components/src/table/table.tsx#L158-L174 ) doesn't account for whether the table is scrollable based on the new window dimensions. The updateTableShadow seems to be applying only scroll position changes, but doesn't handle whether the table is scrollable at all.
…does-not-disappear-on-resize
…does-not-disappear-on-resize
FYI @frosso I just opened this pull request that addresses the root cause in the |
…does-not-disappear-on-resize
rtio
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #WOOPMNT-5217
This PR fixes an issue where the linear gradient overlay on WooCommerce Payments tables remains visible after resizing the viewport back to a larger size.
Changes proposed in this Pull Request
client/style.scssto hide the gradient overlay on larger screensTesting instructions
Payments > TransactionsPayments > PayoutsPayments > Disputesnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge