E2E - Fix failures for Shopper: Subscription #11013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 870 kB ℹ️ View Unchanged
|
RadoslavGeorgiev
approved these changes
Aug 22, 2025
opr
requested changes
Aug 22, 2025
| @@ -130,7 +130,7 @@ describeif( shouldRunSubscriptionsTests )( | |||
| const card = config.cards[ '3dsOTP' ]; | |||
| await fillCardDetails( shopperPage, card ); | |||
| await shopperPage | |||
| .getByRole( 'button', { name: 'Sign up now' } ) | |||
| .getByRole( 'button', { name: 'Add to cart', exact: true } ) | |||
There was a problem hiding this comment.
This change probably won't be needed - the change in subscriptions is incorrect as the Checkout page should not say "Add to cart". My guess is that it would be changed back to "Sign up now"
There was a problem hiding this comment.
@opr - thanks for the info. However, the Slack convo is about the Checkout page only, while the problem with our E2E tests is on the single product page (see the screenshot in my PR description, which is from the failed E2E test).
There was a problem hiding this comment.
I am going to merge this PR now. Will follow up the convo and revert the fix if needed, but I don't think that's the case, given looking at your PR too https://github.com/woocommerce/woocommerce-subscriptions/pull/5043
There was a problem hiding this comment.
Thanks for checking! I appreciate the reply and info.
There was a problem hiding this comment.
But hold on, earlier in this test, line 115 it says:
// Proceed to the checkout page and verify that the 14-day free trial is shown in the product line item,
// and that the first renewal date is 14 days from now.
await setupCheckout( shopperPage, customerBilling );
You may want to double check this one after my PR is merged in subscriptions
There was a problem hiding this comment.
Oh @opr, you're totally right. We will need to update it back to Place order or Sign up now when the next version of WooCommerce Subscription is released!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WOOPMNT-5278
Errors from multiple branches recently in
WC - latest | subscriptions - shopperFor example, PR #11009 with this job log https://github.com/Automattic/woocommerce-payments/actions/runs/17140352651/job/48626327524
Root cause
From screenshots in the artifact, it seems all
Sign up nowtexts have been changed to the default Woo button textAdd to cartThis matches with the latest release of WooCommerce Subscriptions 7.8.0 on Aug 20 with this PR https://github.com/woocommerce/woocommerce-subscriptions/pull/4970
Changes proposed in this Pull Request
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge