[Disputes] Introduce a loading state to the “Challenge dispute” (new evidence) flow #11037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +288 B (0%) Total Size: 871 kB
ℹ️ View Unchanged
|
|
Closing since this change is needed to stabilize flaky tests in #11036 |
This reverts commit 9370ddc.
|
Re-opening, see comment |
mgascam
changed the title
mgascam
changed the title
6 tasks
rtio
approved these changes
Sep 8, 2025
|
Hi @htdat, I saw the pr: needs author reply label was added. I might be overlooking something, but I don’t see any pending feedback. Could you point me to what needs my attention? |
|
@mgascam - I thought that you're waiting for feedback from Design :) Feel free to merge, I do not have any further comment. |
|
@mgascam looks good! thanks for working on this. The loader you used comes from the design system, right? Just double checking. Otherwise approved on my end. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #WOOPMNT-5307
Changes proposed in this Pull Request
This PR introduces a loading state that helps to fix a race condition in the disputes E2E tests. In the "Save for later" flow, the description is changed from "Beanie" to "my product description" and saved. However, when the dispute is revisited later, the form incorrectly shows the old value ("Beanie") instead of the updated one. Run logs
Introducing the initial loading state removes the UI race that caused flakiness and also improves the perceived performance and UX flow.
Here's a screen recording of the new spinner in action:
Screen.Recording.2025-09-08.at.17.15.49.mov
Testing instructions
Manual tests of the flow should work as expected:
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge