-
Notifications
You must be signed in to change notification settings - Fork 72
Support Agentic Commerce Protocol #11076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…h /checkout_sessions/{checkout_session_id}/complete
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 873 kB ℹ️ View Unchanged
|
I didn't functionally test, but the code makes sense to me. It's nice to see how simple/clean it is. I guess my biggest question is why the CI is broken. But, once we fix that, this seems pretty good to me. |
|
||
if ( $blocked_by_fraud_rules ) { | ||
$this->order_service->mark_order_blocked_for_fraud( $order, '', Intent_Status::CANCELED ); | ||
} elseif ( $e instanceof Process_Payment_Exception && 'rate_limiter_enabled' === $e->get_error_code() ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to move this specific handling of rate_limiter_enabled
exception because of:
- the move of
$payment_information = $this->prepare_payment_information( $order );
to the initial phase ofprocess_payment
. - since this handling is more specific than the next one
! empty( $payment_information )
, I would like to move it here, otherwise, two failure notes will be added.
Provide Agentic Commerce support based on woocommerce/woocommerce#61271
Related: WOOPTP-20
Changes proposed in this Pull Request
Testing instructions
pm_card_visa
, it's not needed to apply the server change.npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge