-
Notifications
You must be signed in to change notification settings - Fork 2k
Studio banner: Update wording and link design #106887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Studio banner: Update wording and link design #106887
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
sejas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me. I confirm the button doesn't seem "disabled" anymore.
I wonder if @alexapeduzzi or @ndiego have any feedback.
wojtekn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
| external | ||
| > | ||
| { translate( 'Connect Studio' ) } | ||
| { translate( 'Open in Studio' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am just wondering, are we supposed to get a specific site opened in Studio? Because when I am testing, I seem to be brought up to the site that I have previously opened in Studio rather than a Studio site related to the purchase 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it should be "Open your Studio site to start syncing." and "Open Studio" instead?
katinthehatsite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…studio-improve-the-calypso-banner-after-purchasing-a-site
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
katinthehatsite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks better 👍
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/29635540 Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @epeicher for including a screenshot in the description! This is really helpful for our translators. |

Resolves STU-913
Further context p1761154028496639-slack-C06DRMD6VPZ
Proposed Changes
Connect SudiolinkWhy are these changes being made?
Testing Instructions
yarn startor open Calypso Live link belowstudioSiteIdquery param with a fake value, e.g./home/<site_id>?studioSiteId=aaaareplacing<site_id>with a validblog_idPre-merge Checklist