refactor: make principal type optional in role assignments and clean up e2e tests #1884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces improvements to the role assignment module in the infrastructure code, making principal type detection more flexible and simplifying usage in main deployment scripts. It also includes minor cleanups in the end-to-end test scripts for better readability.
Infrastructure improvements:
core/security/role.bicep
to allow automatic principal type detection by makingprincipalType
optional and including it only if explicitly provided. This enables more flexible role assignments for different principal types.principalType: 'User'
assignments in the main infrastructure deployment (infra/main.bicep
), so principal type is now auto-detected unless specifically set. This reduces redundancy and potential errors. [1] [2] [3]Test script cleanups:
tests/e2e-test/tests/test_chat_with_your_data.py
for better readability.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information