Skip to content

Conversation

@rllyy97
Copy link
Contributor

@rllyy97 rllyy97 commented Nov 6, 2025

Commit Type

  • feature - New functionality

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Can now load standalone designer from url search params.

  • plan - Standard / Consumption
  • id - Remote workflow id
  • runId - Remote workflow run id
  • localId - Local workflow id
  • localRunId - Local workflow run id

The intention of this is to speed up workflow initialization during our automated testing to avoid waiting on all LA / workflow resources to load before the proper workflow can be selected.

Impact of Change

  • Users: N/A
  • Developers: Faster PR integration due to decreased E2E test durations
  • System: Decreased E2E test suite durations

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@rllyy97

Screenshots/Videos

N/A

Copilot AI review requested due to automatic review settings November 6, 2025 18:09
@rllyy97 rllyy97 added the risk:low Low risk change with minimal impact label Nov 6, 2025
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: feat(Designer): Direct standalone initialization
  • Issue: Title accurately summarizes the PR. It is clear, scoped, and descriptive.
  • Recommendation: No changes needed. Good job being explicit and concise!

Commit Type

  • Properly selected (feature)
  • Only one selected, which is correct.

Risk Level

  • Risk level marked as Low and matches the code change and risk label.

What & Why

  • Current:

    Can now load standalone designer from url search params.

    • plan - Standard / Consumption
    • id - Remote workflow id
    • runId - Remote workflow run id
    • localId - Local workflow id
    • localRunId - Local workflow run id
      The intention of this is to speed up workflow initialization during our automated testing to avoid waiting on all LA / workflow resources to load before the proper workflow can be selected.
  • Issue: Well written, clear explanation of what is being changed and why.
  • Recommendation: No changes needed. Good context and brevity.

Impact of Change

  • Clearly scoped:
    • Users: N/A
    • Developers: Faster PR integration due to decreased E2E test durations
    • System: Decreased E2E test suite durations
  • Recommendation: No change needed.

Test Plan

  • E2E tests and manual testing confirmed. Unit and environment specific testing not checked, which is fine for current context.

⚠️ Contributors

  • Only self-tagged. To strengthen this section, consider acknowledging PMs or designers if relevant, especially if contributed feedback.

Screenshots/Videos

  • Marked N/A and appropriate for non-visual change.

Summary Table

Section Status Recommendation
Title None
Commit Type None
Risk Level None
What & Why None
Impact of Change None
Test Plan None
Contributors ⚠️ Nudge to mention others if relevant
Screenshots/Videos None

PR passes all required checks and matches the assigned risk level. If you worked with other contributors, consider tagging them for visibility and recognition. Well done! 🎉


Last updated: Thu, 06 Nov 2025 19:30:53 GMT

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors E2E test workflow loading to use direct URL parameters instead of UI interactions, and implements corresponding URL parameter handling in the standalone application. The changes enable faster test execution by bypassing the workflow selection UI.

  • Replaced GoToMockWorkflow with LoadMockDirect function that loads workflows via URL parameters
  • Added URL parameter parsing logic to automatically configure workflow/run settings on page load
  • Removed redundant page.goto('/') calls from real API tests since goToWorkflow() handles navigation

Reviewed Changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
e2e/designer/utils/GoToWorkflow.ts Added LoadMockDirect and LoadDirect helper functions for URL-based workflow loading
e2e/designer/workflowParametersPanel.spec.ts Updated to use direct loading with workflow filename instead of display name
e2e/designer/variables/ensureInitializeVariable.spec.ts Replaced UI-based workflow selection with direct URL loading
e2e/designer/unicodeCharacters.spec.ts Updated to use direct URL loading
e2e/designer/tokens/tokenRemoval.spec.ts Removed redundant page navigation and switched to direct loading
e2e/designer/tokens/escapeExpressionTokens.spec.ts Updated to use direct URL loading
e2e/designer/tabFocus.spec.ts Replaced UI-based workflow selection with direct loading
e2e/designer/serialization.spec.ts Updated to use direct URL loading
e2e/designer/scopeActions.spec.ts Replaced UI-based workflow selection with direct loading
e2e/designer/runAfter.spec.ts Updated to use direct URL loading
e2e/designer/recurrence.spec.ts Replaced UI-based workflow selection with direct loading
e2e/designer/real-api/operationPanel/triggerUpdateName.spec.ts Removed redundant page.goto('/') since goToWorkflow() handles navigation
e2e/designer/real-api/operationPanel/operationParameters.spec.ts Removed redundant page navigation
e2e/designer/real-api/monitoring/NestedLoops/nestedLoops.spec.ts Removed redundant page navigation
e2e/designer/real-api/editors/htmleditor.spec.ts Removed redundant page navigation
e2e/designer/real-api/custom-code/custom-code.spec.ts Removed redundant page navigation
e2e/designer/real-api/connections/connectionAuth.spec.ts Removed redundant page navigation
e2e/designer/real-api/agentic/agentConnections.spec.ts Removed redundant page navigation and reload since goToWorkflow() handles it
e2e/designer/real-api/StatelessVariables/statelessvariables.spec.ts Removed redundant page navigation
e2e/designer/real-api/SanityTest/sanity-test.spec.ts Removed redundant page navigation
e2e/designer/queryCache.spec.ts Updated workflow loading to use direct URL parameters
e2e/designer/operationPanel.spec.ts Replaced UI-based workflow selection with direct loading
e2e/designer/nodeSearchPanel.spec.ts Updated to use direct URL loading with corrected filename
e2e/designer/monitoringView/monitoringView.spec.ts Replaced workflow and run file loading with direct URL parameters
e2e/designer/monitoringView/loopsPager.spec.ts Updated to load workflow and run via URL parameters
e2e/designer/mock-copypastescope.spec.ts Updated to use direct URL loading
e2e/designer/graphCollapse.spec.ts Replaced UI-based workflow selection with direct loading
e2e/designer/fixtures/real-api.ts Refactored goToWorkflow to use direct URL navigation instead of UI interactions
e2e/designer/errorsPanel.spec.ts Updated to use direct URL loading
e2e/designer/editors/password.spec.ts Updated to use direct URL loading
e2e/designer/editors/dictionary.spec.ts Updated to use direct URL loading
e2e/designer/editors/condition.spec.ts Updated to use direct URL loading
e2e/designer/dragAndDrop.spec.ts Updated to use direct URL loading
e2e/designer/contextMenus.spec.ts Updated to use direct URL loading
e2e/designer/collapseActions.spec.ts Updated to use direct URL loading
e2e/designer/app.spec.ts Updated to use direct URL loading
e2e/designer/TokenPicker.spec.ts Updated to use direct URL loading
apps/Standalone/src/designer/components/settings_box.tsx Added logic to auto-hide settings box when loading workflows via URL parameters
apps/Standalone/src/designer/app/SettingsSections/sourceSettings.tsx Added URL parameter parsing to set hosting plan, local mode, and monitoring view on load
apps/Standalone/src/designer/app/LocalDesigner/LogicAppSelector/LogicAppSelector.tsx Implemented URL parameter handling to auto-select workflow and run files
apps/Standalone/src/designer/app/AzureLogicAppsDesigner/LogicAppSelectionSetting/AzureStandardLogicAppSelector.tsx Added URL parameter parsing to auto-populate app, workflow, and run selections
apps/Standalone/src/designer/app/AzureLogicAppsDesigner/LogicAppSelectionSetting/AzureConsumptionLogicAppSelector.tsx Implemented URL parameter handling for consumption workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:low Low risk change with minimal impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants