Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 7, 2025

Cherry-pick of PR #8546 into hotfix/v5.230 branch

Plan

  • Create branch cherry-pick-f2404e1a1-into-hotfix-v5.230 from hotfix/v5.230
  • Cherry-pick commit f2404e1
  • Verify no conflicts (cherry-pick was clean - no conflicts)
  • Install dependencies and ensure build passes
  • Run existing unit tests for DesignerV2
  • Add smoke tests if needed for new functionality
  • Update changelog/release notes for hotfix branch
  • Verify isDraft option and change count selector work correctly
  • Final code review and validation
  • Complete PR with appropriate labels

Changes

The cherry-pick includes:

  • Added global change count selector that increments when dirty flag is set
  • Added isDraft designer option to DesignerOptionsState
  • Updated workflow, workflowparameters, and notes slices to track changeCount
  • Exported new selectors: useChangeCount, useIsDraft, useWorkflowChangeCount, useWorkflowParametersChangeCount, useNotesChangeCount

Status

Cherry-pick completed successfully with no conflicts. All 13 files applied cleanly.

Original prompt

Please create a new pull request that cherry-picks commit f2404e1 (from the already merged PR #8546: feat(DesignerV2): Added global change count selector, isDraft designer option) onto the base branch hotfix/v5.230.

Acceptance criteria:

  1. Create a new branch off of hotfix/v5.230 (proposed name: cherry-pick-f2404e1a1-into-hotfix-v5.230) and cherry-pick the specified commit.
  2. Resolve any merge/cherry-pick conflicts. Document resolutions inline with code comments if non-trivial.
  3. Ensure build passes and DesignerV2 changes are correctly scoped for the hotfix (no unintended additional commits from the original feature branch).
  4. Update any versioned changelog or release notes file (if the repo maintains one for hotfix branches) to include a short entry referencing the cherry pick of PR feat(DesignerV2): Added global change count selector, isDraft designer option #8546.
  5. Verify that the isDraft designer option and global change count selector function as expected in the hotfix context (no dependence on code only present in later main branch versions). If stubs or guards are needed, add them.
  6. Run existing unit tests / integration tests related to DesignerV2; if none exist, add minimal smoke test ensuring the new selector renders and isDraft can be toggled without error.
  7. Keep diff minimal: only the cherry-picked changes plus necessary conflict resolutions and tests/changelog updates.
  8. Add PR description summarizing why cherry-pick was needed and any conflict resolutions.

If the commit cannot be cleanly cherry-picked (e.g., missing dependencies), please adapt by selectively applying the commit's changes and note deviations in the PR description.

Do NOT include unrelated changes. Assign appropriate labels (e.g., hotfix, cherry-pick) if available.

This pull request was created as a result of the following prompt from Copilot chat.

Please create a new pull request that cherry-picks commit f2404e1 (from the already merged PR #8546: feat(DesignerV2): Added global change count selector, isDraft designer option) onto the base branch hotfix/v5.230.

Acceptance criteria:

  1. Create a new branch off of hotfix/v5.230 (proposed name: cherry-pick-f2404e1a1-into-hotfix-v5.230) and cherry-pick the specified commit.
  2. Resolve any merge/cherry-pick conflicts. Document resolutions inline with code comments if non-trivial.
  3. Ensure build passes and DesignerV2 changes are correctly scoped for the hotfix (no unintended additional commits from the original feature branch).
  4. Update any versioned changelog or release notes file (if the repo maintains one for hotfix branches) to include a short entry referencing the cherry pick of PR feat(DesignerV2): Added global change count selector, isDraft designer option #8546.
  5. Verify that the isDraft designer option and global change count selector function as expected in the hotfix context (no dependence on code only present in later main branch versions). If stubs or guards are needed, add them.
  6. Run existing unit tests / integration tests related to DesignerV2; if none exist, add minimal smoke test ensuring the new selector renders and isDraft can be toggled without error.
  7. Keep diff minimal: only the cherry-picked changes plus necessary conflict resolutions and tests/changelog updates.
  8. Add PR description summarizing why cherry-pick was needed and any conflict resolutions.

If the commit cannot be cleanly cherry-picked (e.g., missing dependencies), please adapt by selectively applying the commit's changes and note deviations in the PR description.

Do NOT include unrelated changes. Assign appropriate labels (e.g., hotfix, cherry-pick) if available.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants