test(designer): Adding tests for V1ChatCompletionsService #8644

Eric-B-Wu · 2025-12-05T17:36:05Z

Commit Type

feature - New functionality
fix - Bug fix
refactor - Code restructuring without behavior change
perf - Performance improvement
docs - Documentation update
test - Test-related changes
chore - Maintenance/tooling

Risk Level

Low - Minor changes, limited scope
Medium - Moderate changes, some user impact
High - Major changes, significant user/system impact

What & Why

Adding some unit tests for v1chatcompletions PR #8639

Impact of Change

Users: No user changes
Developers: A few new unit tests added
System: no system changes

Test Plan

Unit tests added/updated
E2E tests added/updated
Manual testing completed
Tested in:

Contributors

@Eric-B-Wu

Screenshots/Videos

github-actions · 2025-12-05T17:36:25Z

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

Current: test(designer): Adding tests for V1ChatCompletionsService
Issue: None — title is clear, follows conventional scope/type format and describes the change (adding tests).
Recommendation: None — good job using a concise, descriptive title.

✅ Commit Type

Properly selected (test).
Only one commit type is selected, which is correct.

✅ Risk Level

The PR body marks Low and the repository labels include risk:low — these match and are appropriate given the changes are tests and small e2e tweaks.

✅ What & Why

Current: "Adding some unit tests for v1chatcompletions PR feat(designer): Adding support for V1ChatCompletionsService (Bring your own agent) #8639"
Issue: None — brief and links back to the related PR for context.
Recommendation: If you want to be extra helpful to reviewers, you can add 1-2 lines summarizing the functional area or which modules the tests target (but this is optional).

⚠️ Impact of Change

No major issues; the section is populated.
Recommendation: Keep as-is.
- Users: No user changes — correct.
- Developers: A few new unit tests added — correct.
- System: No system changes — correct.

⚠️ Test Plan

Assessment: Mostly correct — you checked Unit tests added/updated, and the code diff indeed adds multiple unit test files.
Issue: The diff also includes modifications to e2e test files (e2e/chatClient/tests/features/sessions/session-management.spec.ts and e2e/chatClient/tests/smoke/basic-chat.spec.ts), which are updates to E2E tests. In the PR body the E2E tests added/updated box is NOT checked.
Recommendation: Update the Test Plan section to either:
- Check E2E tests added/updated (since there are e2e test changes), or
- Add a short explanation in Test Plan why the e2e changes are not considered an E2E test update (for example: if the changes are only minor formatting/strictness fixes and you intentionally omitted the E2E checkbox). Usually the correct action is to check the E2E box because there are test modifications.

✅ Contributors

Assessment: Contributors field includes @eric-b-wu — acceptable.
Recommendation: Optional: Add any other reviewers or contributors if applicable.

⚠️ Screenshots/Videos

Assessment: Not applicable (no UI changes). This is fine.
Recommendation: None.

Summary Table

Section	Status	Recommendation
Title	✅	No change needed.
Commit Type	✅	No change needed.
Risk Level	✅	No change needed (risk:low matches labels).
What & Why	✅	Clear and linked to related PR.
Impact of Change	✅	No change needed.
Test Plan	⚠️	Check `E2E tests added/updated` or explain why not.
Contributors	✅	No change needed.
Screenshots/Videos	⚠️	Not applicable — OK to leave blank.

Final message:
This PR is acceptable to merge from a PR title/body compliance perspective. The only required update is in the Test Plan: please either mark E2E tests added/updated (because the diff modifies e2e test files) or add a brief justification in the Test Plan for why the E2E checkbox should remain unchecked. Once that small update is made, the PR description will be fully aligned with the code changes.

Thank you for adding comprehensive unit tests — they look thorough and appropriate for this change set. If you want, after updating the Test Plan I can re-run this check and confirm final pass.

Last updated: Mon, 05 Jan 2026 19:20:23 GMT

Copilot

Pull request overview

This PR adds unit tests for the V1ChatCompletionsService feature, covering utility functions in AgentUtils and parameter validation logic for agent operations. The tests are added to both the designer and designer-v2 libraries, providing coverage for connector identification, parameter type checking, and model type validation.

Key Changes

Added comprehensive tests for AgentUtils utility class methods (isConnector, isDeploymentOrModelIdParameter, isAgentModelTypeParameter)
Added tests for isParameterRequired function covering agent-specific parameter validation logic
Added tests for createParameterInfo function focusing on agent parameter requirements

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 12 comments.

File	Description
libs/designer/src/lib/core/utils/parameters/test/helper-agentParams.test.ts	Tests for parameter validation logic for agent operations, including `isParameterRequired` and `createParameterInfo` functions
libs/designer/src/lib/common/utilities/test/Utils.test.ts	Tests for `AgentUtils` class methods and `isDynamicConnection` utility function
libs/designer-v2/src/lib/core/utils/parameters/test/helper-agentParams.test.ts	Mirror of designer library tests for parameter validation in designer-v2
libs/designer-v2/src/lib/common/utilities/test/Utils.test.ts	Mirror of designer library tests for utility functions in designer-v2

Comments suppressed due to low confidence (10)

libs/designer/src/lib/core/utils/parameters/test/helper-agentParams.test.ts:230

Superfluous arguments passed to function createParameterInfo.

      const parameterInfo = createParameterInfo(parameter, true, {}, undefined, undefined, undefined, false);

libs/designer/src/lib/core/utils/parameters/test/helper-agentParams.test.ts:249

Superfluous arguments passed to function createParameterInfo.

      const parameterInfo = createParameterInfo(parameter, true, {}, undefined, undefined, undefined, false);

libs/designer/src/lib/core/utils/parameters/test/helper-agentParams.test.ts:268

Superfluous arguments passed to function createParameterInfo.

      const parameterInfo = createParameterInfo(parameter, true, {}, undefined, undefined, undefined, false);

libs/designer/src/lib/core/utils/parameters/test/helper-agentParams.test.ts:286

Superfluous arguments passed to function createParameterInfo.

      const parameterInfo = createParameterInfo(parameter, true, {}, undefined, undefined, undefined, false);

libs/designer/src/lib/core/utils/parameters/test/helper-agentParams.test.ts:312

Superfluous arguments passed to function createParameterInfo.

      const parameterInfo = createParameterInfo(parameter, true, {}, undefined, undefined, undefined, false);

libs/designer-v2/src/lib/core/utils/parameters/test/helper-agentParams.test.ts:230

Superfluous arguments passed to function createParameterInfo.

      const parameterInfo = createParameterInfo(parameter, true, {}, undefined, undefined, undefined, false);

libs/designer-v2/src/lib/core/utils/parameters/test/helper-agentParams.test.ts:249

Superfluous arguments passed to function createParameterInfo.

      const parameterInfo = createParameterInfo(parameter, true, {}, undefined, undefined, undefined, false);

libs/designer-v2/src/lib/core/utils/parameters/test/helper-agentParams.test.ts:268

Superfluous arguments passed to function createParameterInfo.

      const parameterInfo = createParameterInfo(parameter, true, {}, undefined, undefined, undefined, false);

libs/designer-v2/src/lib/core/utils/parameters/test/helper-agentParams.test.ts:286

Superfluous arguments passed to function createParameterInfo.

      const parameterInfo = createParameterInfo(parameter, true, {}, undefined, undefined, undefined, false);

libs/designer-v2/src/lib/core/utils/parameters/test/helper-agentParams.test.ts:312

Superfluous arguments passed to function createParameterInfo.

      const parameterInfo = createParameterInfo(parameter, true, {}, undefined, undefined, undefined, false);

libs/designer-v2/src/lib/core/utils/parameters/__test__/helper-agentParams.test.ts

libs/designer/src/lib/core/utils/parameters/__test__/helper-agentParams.test.ts

libs/designer-v2/src/lib/core/utils/parameters/__test__/helper-agentParams.test.ts

libs/designer/src/lib/core/utils/parameters/__test__/helper-agentParams.test.ts

libs/designer-v2/src/lib/core/utils/parameters/__test__/helper-agentParams.test.ts

Copilot · 2025-12-05T20:26:44Z

@Eric-B-Wu I've opened a new pull request, #8646, to work on those changes. Once the pull request is ready, I'll request review from you.

github-actions · 2026-01-05T18:58:00Z

📊 Coverage check completed. See workflow run for details.

…/v1ChatCompletionTest

github-actions · 2026-01-05T19:04:56Z

📊 Coverage check completed. See workflow run for details.

…LogicAppsUX into eric/v1ChatCompletionTest

github-actions · 2026-01-05T19:21:00Z

📊 Coverage check completed. See workflow run for details.

Eric-B-Wu added 10 commits June 30, 2025 08:04

remove python connector

26ddd6a

Merge branch 'main' of https://github.com/Azure/logic_apps_designer

e5bf318

Merge branch 'main' of https://github.com/Azure/logic_apps_designer

85efe57

Merge branch 'main' of https://github.com/Azure/logic_apps_designer

9e37b24

Merge branch 'main' of https://github.com/Azure/logic_apps_designer

fd0c8a2

Merge branch 'main' of https://github.com/Azure/logic_apps_designer

f0d3c0d

Merge branch 'main' of https://github.com/Azure/logic_apps_designer

01a6509

Merge branch 'main' of https://github.com/Azure/logic_apps_designer

ea09a9a

Merge branch 'main' of https://github.com/Azure/logic_apps_designer

96eef6f

add unit tests

fda34bc

Copilot AI review requested due to automatic review settings December 5, 2025 17:36

Eric-B-Wu added the risk:low Low risk change with minimal impact label Dec 5, 2025

github-actions bot added the pr-validated label Dec 5, 2025

Copilot started reviewing on behalf of Eric-B-Wu December 5, 2025 17:36 View session

Copilot finished reviewing on behalf of Eric-B-Wu December 5, 2025 17:39

rllyy97 approved these changes Dec 5, 2025

View reviewed changes

Copilot AI reviewed Dec 5, 2025

View reviewed changes

Copilot AI mentioned this pull request Dec 5, 2025

Rename test file to follow .spec.ts naming convention #8646

Closed

14 tasks

fix tests

d447105

Eric-B-Wu and others added 2 commits January 5, 2026 11:03

Merge branch 'main' into eric/v1ChatCompletionTest

8c119e1

Merge branch 'main' of https://github.com/Azure/LogicAppsUX into eric…

b0c7ca7

…/v1ChatCompletionTest

Eric-B-Wu added 2 commits January 5, 2026 11:18

fix test

77a7444

Merge branch 'eric/v1ChatCompletionTest' of https://github.com/Azure/…

69b140c

…LogicAppsUX into eric/v1ChatCompletionTest

Eric-B-Wu merged commit 8cb3426 into main Jan 5, 2026
13 checks passed

Eric-B-Wu deleted the eric/v1ChatCompletionTest branch January 5, 2026 19:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(designer): Adding tests for V1ChatCompletionsService #8644

test(designer): Adding tests for V1ChatCompletionsService #8644

Uh oh!

Eric-B-Wu commented Dec 5, 2025

Uh oh!

github-actions bot commented Dec 5, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Dec 5, 2025

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

test(designer): Adding tests for V1ChatCompletionsService #8644

test(designer): Adding tests for V1ChatCompletionsService #8644

Uh oh!

Conversation

Eric-B-Wu commented Dec 5, 2025

Commit Type

Risk Level

What & Why

Impact of Change

Test Plan

Contributors

Screenshots/Videos

Uh oh!

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

✅ Commit Type

✅ Risk Level

✅ What & Why

⚠️ Impact of Change

⚠️ Test Plan

✅ Contributors

⚠️ Screenshots/Videos

Summary Table

Thank you for adding comprehensive unit tests — they look thorough and appropriate for this change set. If you want, after updating the Test Plan I can re-run this check and confirm final pass.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Dec 5, 2025

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 5, 2025 •

edited

Loading