-
Notifications
You must be signed in to change notification settings - Fork 96
fix(DesignerV2): Fixed a few V2-Consumption related issues #8665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
✅ Contributors
✅ Screenshots/Videos
Summary Table
Final message: This PR passes the PR-title/body checks. The advised risk level from the diff is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes three V2-Consumption related bugs to improve reliability and compatibility. The changes address version parsing for private bundles with 4-part version numbers, null-safety in run repetition data handling, and resource loading failures in consumption environments by reducing query page size.
Key Changes
- Modified version parsing to accept 4+ part version numbers while still comparing only major.minor.patch
- Added null-safe optional chaining for repetition type checks in the run tree view
- Reduced Azure Resource Graph API page size from 500 to 300 to prevent resource loading failures
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| libs/logic-apps-shared/src/utils/src/lib/helpers/version.ts | Changed validation from exactly 3 parts to at least 3 parts to support 4-part private bundle version numbers |
| libs/designer-v2/src/lib/ui/panel/runTreeView/TreeActionItem.tsx | Added optional chaining to three data.repetition.type accesses for null-safety when handling agentic repetitions |
| apps/Standalone/src/designer/app/AzureLogicAppsDesigner/Utilities/resourceUtilities.ts | Reduced page size from 500 to 300 in Azure Resource Graph query to prevent failures in consumption environments |
Commit Type
Risk Level
What & Why
Fixes several issues:
Impact of Change
Test Plan
Contributors
@rllyy97
Screenshots/Videos
N/A