Skip to content

Conversation

@rllyy97
Copy link
Contributor

@rllyy97 rllyy97 commented Dec 16, 2025

Commit Type

  • fix - Bug fix

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Fixes several issues:

  • Standalone page size decreased to prevent resource loading failures in consumption
  • Run repetition data now properly null-safe in the log tree
  • Properly accounted for >3 version parts with our version check
    • Backend uses 4 part version numbers for private bundles

Impact of Change

  • Users: N/A, fixes are not yet customer facing
  • Developers: Standalone will properly load resources, private bundles will soon be supported in portal
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@rllyy97

Screenshots/Videos

N/A

@rllyy97 rllyy97 added the risk:low Low risk change with minimal impact label Dec 16, 2025
Copilot AI review requested due to automatic review settings December 16, 2025 19:38
@rllyy97 rllyy97 enabled auto-merge (squash) December 16, 2025 19:39
@github-actions
Copy link

github-actions bot commented Dec 16, 2025

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

  • Current: fix(DesignerV2): Fixed a few V2-Consumption related issues
  • Issue: Minor style nit: the title uses past tense ("Fixed"); conventional commit-style PR titles typically use present tense ("fix:"). Otherwise clear and descriptive enough for this change set.
  • Recommendation: Use present tense and consider being slightly more specific about the fixes. Example: fix(DesignerV2): address V2-Consumption resource loading and run repetition issues

✅ Commit Type

  • Properly selected (fix) and only one option is checked.
  • Note: This aligns with the changes in the diff (bug fixes and null-safety improvements).

✅ Risk Level

  • The PR body marks Low and the PR has label risk:low — they match.
  • Assessment from the diff: I reviewed the changes (pageSize reduction, null-safety optional chaining, version parsing relaxation, and an added unit test). These are small, focused updates; advised risk: Low.

✅ What & Why

  • Current:
    Fixes several issues:
    • Standalone page size decreased to prevent resource loading failures in consumption
    • Run repetition data now properly null-safe in the log tree
    • Properly accounted for >3 version parts with our version check (Backend uses 4 part version numbers for private bundles)
  • Issue: None blocking — good brief summary.
  • Recommendation: Optionally add a 1-line note describing why the trunk/portal behaviour benefits (e.g., which user flows are more reliable) to help reviewers understand scope quickly.

✅ Impact of Change

  • Impact section is present but a couple of fields are marked N/A.
  • Recommendation: Expand slightly so consumers/maintainers can scan impact quickly:
    • Users: None immediately (internal runtime fixes) — or state which customer scenario was failing if known.
    • Developers: Standalone resource loading more reliable; version parsing now tolerates 4+ part versions (may enable private bundle support).
    • System: No major architecture changes; page size reduced to 300 to avoid timeouts/resource failures.

✅ Test Plan

  • Unit tests added/updated (test added for >3-part versions).
  • Manual testing completed.
  • E2E not included (marked as not updated) — this is reasonable for these focused fixes, but consider adding an E2E if the change touches an integrated flow later.

✅ Contributors

  • @rllyy97 is credited.

✅ Screenshots/Videos

  • N/A — appropriate for non-visual fixes.

Summary Table

Section Status Recommendation
Title Use present tense and optionally be slightly more specific
Commit Type None
Risk Level None (advised: risk:low)
What & Why Optionally add one short sentence on the user-visible motivation
Impact of Change Expand Users/System lines slightly for clarity
Test Plan None
Contributors None
Screenshots/Videos None

Final message: This PR passes the PR-title/body checks. The advised risk level from the diff is risk:low, which matches the label and the PR body. Recommendations are small wording/clarity improvements only (title tense and slightly expand the Impact section). Please update the title if you prefer the present-tense conventional-commit style and optionally expand the Impact section with a line about the affected flows, then proceed with review/merge. Thank you!


Last updated: Tue, 16 Dec 2025 19:48:58 GMT

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes three V2-Consumption related bugs to improve reliability and compatibility. The changes address version parsing for private bundles with 4-part version numbers, null-safety in run repetition data handling, and resource loading failures in consumption environments by reducing query page size.

Key Changes

  • Modified version parsing to accept 4+ part version numbers while still comparing only major.minor.patch
  • Added null-safe optional chaining for repetition type checks in the run tree view
  • Reduced Azure Resource Graph API page size from 500 to 300 to prevent resource loading failures

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
libs/logic-apps-shared/src/utils/src/lib/helpers/version.ts Changed validation from exactly 3 parts to at least 3 parts to support 4-part private bundle version numbers
libs/designer-v2/src/lib/ui/panel/runTreeView/TreeActionItem.tsx Added optional chaining to three data.repetition.type accesses for null-safety when handling agentic repetitions
apps/Standalone/src/designer/app/AzureLogicAppsDesigner/Utilities/resourceUtilities.ts Reduced page size from 500 to 300 in Azure Resource Graph query to prevent failures in consumption environments

@rllyy97 rllyy97 merged commit 3d89fd1 into main Dec 16, 2025
12 checks passed
@rllyy97 rllyy97 deleted the riley/designer-v2-error-fixes branch December 16, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:low Low risk change with minimal impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants