-
Notifications
You must be signed in to change notification settings - Fork 95
Fix connector name visibility in dark theme for API Center MCP registration #8674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: hartra344 <[email protected]>
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
❌ Risk Level
✅ What & Why
✅ Impact of Change
❌ Test Plan
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | Title is good and descriptive. |
| Commit Type | ✅ | fix selected correctly. |
| Risk Level | ❌ | Add matching PR label (e.g. risk:low) to match body. |
| What & Why | ✅ | Good. Optionally link to changed file. |
| Impact of Change | ✅ | Good; consider clarifying "no API changes". |
| Test Plan | ❌ | Fix mismatch: add tests or update Test Plan + provide evidence. |
| Contributors | Optional: credit contributors if applicable. | |
| Screenshots/Videos | Add before/after screenshots for visual verification. |
Final Notes
- Advised risk level from the diff:
risk:low(matches PR body). No change needed to the risk selection itself — however, you must add the corresponding PR label (risk:low). - Primary blockers for passing this PR review currently:
- Missing/incorrect Test Plan vs actual diff (either add unit tests to the PR or update the Test Plan to reflect manual testing and include the verification steps and evidence).
- Missing repository risk label (
risk:low).
Please update the PR with the requested changes (add the risk label, correct the Test Plan checkboxes or include the test files, and attach screenshots showing the fix), then re-submit. Thank you for the clear description and the small, focused fix — once the test and label issues are resolved this should be good to merge.
Last updated: Wed, 17 Dec 2025 23:07:10 GMT
|
📊 Coverage check completed. See workflow run for details. |
Commit Type
Risk Level
What & Why
Connector names were invisible in dark theme during MCP server registration in API Center due to insufficient CSS selector specificity. The dark theme text color rule was being overridden by the base selector.
Impact of Change
Test Plan
Technical Details:
CSS selector specificity issue where
.msla-theme-dark .msla-connector-summary-titlehad equal specificity to base selector.msla-connector-summary-header .msla-connector-summary-title.Before:
After:
This ensures light text (
#fdfdfd) displays on dark background (#323130).Contributors
N/A
Screenshots/Videos
N/A
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.