-
Notifications
You must be signed in to change notification settings - Fork 95
(feat): Adding A2A In Search Menu #8676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:
|
| Section | Status | Recommendation |
|---|---|---|
| Title | Improve to conventional commit format and add scope | |
| Commit Type | ✅ | No change needed |
| Risk Level | ❌ | Update to Medium in body and add risk:medium GitHub label |
| What & Why | ✅ | OK; optionally provide ticket/link |
| Impact of Change | Expand slightly to list specific modules affected | |
| Test Plan | ❌ | Mark Unit tests added/updated and ensure CI runs them |
| Contributors | OK; optionally add more contributors if applicable | |
| Screenshots/Videos | Optional; add if there is a visible UI change |
Final notes and concrete next steps (what to change so this PR can pass):
- Update PR title to follow conventional-commit with scope, e.g.:
feat(search): Add A2A Request to Consumption search menu. - Change Risk Level in PR body from Low to Medium and add the GitHub label
risk:mediumto the PR so body and labels match. (Advised risk isrisk:mediumbased on the diff.) - Update Test Plan checkboxes to reflect the added unit tests:
- Check "Unit tests added/updated" and include a line calling out the added test files (e.g., libs/logic-apps-shared/src/.../search.spec.ts and operationmanifest.spec.ts).
- Ensure the new unit tests run in CI and pass; if there are test failures, fix them before merging.
- (Optional) Add a short note in Impact of Change listing the main files/modules changed (search, consumption manifests, operation manifests, designer consumption files) to help reviewers.
Please update the PR title/body and labels as recommended and re-request review. Thank you for the thorough implementation and tests — once the label and test plan are corrected this should be ready for final review.
Last updated: Fri, 19 Dec 2025 10:37:49 GMT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for the A2A (Agent-to-Agent) Request trigger in the Consumption search menu, enabling users to discover and add A2A triggers when building agentic workflows. The feature introduces a new "nested agent" operation type that allows invoking agent workflows with an agent loop.
Key changes:
- Added
getAgentWorkflows()method to filter workflows with Agent triggers - Introduced
invokeNestedAgentOperationaction for calling nested agent workflows - Added A2A Request trigger group to the search/connector lists
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
libs/logic-apps-shared/src/designer-client-services/lib/search.ts |
Added getAgentWorkflows() interface method for retrieving agent workflows |
libs/logic-apps-shared/src/designer-client-services/lib/consumption/search.ts |
Added A2A operation and group to consumption search connectors and operations |
libs/logic-apps-shared/src/designer-client-services/lib/consumption/operations/invokeWorkflow.ts |
Added invokeNestedAgentOperation definition for nested agent workflow invocation |
libs/logic-apps-shared/src/designer-client-services/lib/consumption/operationmanifest.ts |
Added nestedagent type handling and manifest mapping |
libs/logic-apps-shared/src/designer-client-services/lib/consumption/manifests/invokeNestedAgent.ts |
New manifest defining inputs/outputs for nested agent operation |
libs/logic-apps-shared/src/designer-client-services/lib/consumption/__tests__/operationmanifest.spec.ts |
Added unit tests for nestedagent operation type handling |
libs/logic-apps-shared/src/designer-client-services/lib/base/search.ts |
Implemented getAgentWorkflows() to filter workflows by Agent kind triggers |
libs/logic-apps-shared/src/designer-client-services/lib/base/__test__/search.spec.ts |
Added comprehensive unit tests for agent workflow filtering logic |
libs/logic-apps-shared/src/designer-client-services/lib/__test__/__mocks__/builtInOperationResponse.ts |
Added mock data for invokeNestedAgent operation in tests |
libs/designer/src/lib/ui/panel/recommendation/azureResourceSelection.tsx |
Added UI handling for nested agent workflow selection |
libs/designer/src/lib/common/constants.ts |
Added constant for nested agent workflow action type |
libs/designer-v2/src/lib/ui/panel/recommendation/azureResourceSelection.tsx |
Added UI handling for nested agent workflow selection (designer v2) |
libs/designer-v2/src/lib/common/constants.ts |
Added constant for nested agent workflow action type (designer v2) |
apps/Standalone/src/templates/app/TemplatesConsumption.tsx |
Registered invokenestedagent operation in templates |
apps/Standalone/src/designer/app/AzureLogicAppsDesigner/laDesignerConsumptionV2.tsx |
Registered invokenestedagent operation in designer v2 |
apps/Standalone/src/designer/app/AzureLogicAppsDesigner/laDesignerConsumption.tsx |
Registered invokenestedagent operation in designer v1 |
Localize/lang/strings.json |
Added localization string for agent loop workflow selection |
| properties: { | ||
| iconUri: invokeWorkflowGroup.properties.iconUri, | ||
| brandColor: invokeWorkflowGroup.properties.brandColor, | ||
| summary: 'Choose a Logic Apps workflow', |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The summary says "Choose a Logic Apps workflow" but this is specifically for nested agent workflows. This should be updated to match the description and accurately reflect what this operation does, such as "Choose a nested agent workflow" to be consistent with the operation definition in invokeWorkflow.ts line 55.
| summary: 'Choose a Logic Apps workflow', | |
| summary: 'Choose a nested agent workflow', |
|
|
||
| inputs: { | ||
| type: 'object', | ||
| required: ['host', 'taskMessage'], |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The required field lists 'taskMessage' as a required input parameter, but based on the operation definition and similar patterns for invoke workflow operations, this should be validated. Typically, only the 'host' parameter is required for workflow invocation operations. Verify whether 'taskMessage' is truly mandatory for the nestedagent operation type or if it should be optional.
| required: ['host', 'taskMessage'], | |
| required: ['host'], |
| test('should return manifest for invokeWorkflow operation', async () => { | ||
| const result = await operationManifestService.getOperationManifest('/connectionProviders/workflow', 'invokeWorkflow'); |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test name refers to 'invokeWorkflow' but should be 'invokenestedagent' to match the actual operation being tested. This inconsistency could cause confusion when debugging test failures.
| test('should return manifest for invokeWorkflow operation', async () => { | |
| const result = await operationManifestService.getOperationManifest('/connectionProviders/workflow', 'invokeWorkflow'); | |
| test('should return manifest for invokenestedagent operation', async () => { | |
| const result = await operationManifestService.getOperationManifest('/connectionProviders/workflow', 'invokenestedagent'); |
Commit Type
Risk Level
What & Why
Added the A2A Request trigger operation group to the Consumption search menu, enabling users to find and add A2A triggers when building agentic workflows.
Impact of Change
Test Plan
Contributors
@Bhavd13
Screenshots/Videos