Skip to content

Update codegen default behavior for is-modular-library true #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Update codegen default behavior for is-modular-library true #3369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8260bea
update codegen default behavior for is-modular-library true
v-jiaodi Jul 9, 2025
f0e23fd
Merge branch 'main' into update-default-behavior
v-jiaodi Jul 9, 2025
868150b
update
v-jiaodi Jul 9, 2025
d47a483
Merge branch 'update-default-behavior' of https://github.com/v-jiaodi…
v-jiaodi Jul 9, 2025
84e93dd
update
v-jiaodi Jul 9, 2025
682b995
update
v-jiaodi Jul 9, 2025
57be1eb
update
v-jiaodi Jul 9, 2025
456cfd2
update
v-jiaodi Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/typespec-test/test/authoring/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ options:
emitter-output-dir: "{project-root}/generated/openapi"
"@azure-tools/typespec-ts":
azure-sdk-for-js: false
is-modular-library: false
generate-sample: true
emitter-output-dir: "{project-root}/generated/typespec-ts"
package-details:
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-test/test/confidentialLedger/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ emit:
options:
"@azure-tools/typespec-ts":
azure-sdk-for-js: false
is-modular-library: false
generate-metadata: true
generate-test: false
emitter-output-dir: "{project-root}/generated/typespec-ts"
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-test/test/contoso/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ options:
"@azure-tools/typespec-ts":
emitter-output-dir: "{project-root}/generated/typespec-ts"
azure-sdk-for-js: false
is-modular-library: false
package-details:
name: "@azure-rest/contosowidgetmanager-rest"
description: "Contoso WidgetManager Service"
1 change: 1 addition & 0 deletions packages/typespec-test/test/customWrapper/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ options:
"@azure-tools/typespec-ts":
azure-sdk-for-js: false
emitter-output-dir: "{project-root}/generated/typespec-ts"
is-modular-library: false
package-details:
name: "@msinternal/customWrapper"
description: "Custom Wrapper Service"
1 change: 1 addition & 0 deletions packages/typespec-test/test/faceai/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ options:
generate-metadata: true
generate-test: true
azure-sdk-for-js: false
is-modular-library: false
emitter-output-dir: "{project-root}/generated/typespec-ts"
package-details:
name: "@azure-rest/ai-face-rest"
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-test/test/healthInsights_trialmatcher/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ options:
generate-test: true
generate-sample: true
azure-sdk-for-js: false
is-modular-library: false
emitter-output-dir: "{project-root}/generated/typespec-ts"
package-details:
name: "@azure-rest/health-insights-clinicalmatching"
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-test/test/loadTest/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ options:
generate-test: true
generate-sample: true
azure-sdk-for-js: false
is-modular-library: false
enable-operation-group: true
package-details:
name: "@azure-rest/load-testing"
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-test/test/openai/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ options:
generate-test: true
generate-sample: true
azure-sdk-for-js: false
is-modular-library: false
emitter-output-dir: "{project-root}/generated/typespec-ts"
package-details:
name: "@msinternal/openai"
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-test/test/translator/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ options:
generate-metadata: true
generate-test: true
azure-sdk-for-js: false
is-modular-library: false
compatibility-query-multi-format: true
package-details:
name: "@azure-rest/cognitiveservices-translator"
Expand Down
11 changes: 2 additions & 9 deletions packages/typespec-ts/src/transform/transfromRLCOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ import {
PackageDetails,
PackageFlavor,
RLCOptions,
ServiceInfo,
isAzurePackage
ServiceInfo
} from "@azure-tools/rlc-common";
import { getHttpOperationWithCache } from "@azure-tools/typespec-client-generator-core";
import { getDoc, NoTarget, Program } from "@typespec/compiler";
Expand Down Expand Up @@ -34,13 +33,7 @@ export function transformRLCOptions(
emitterOptions,
dpgContext.generationPathDetail?.rootDir ?? ""
);
if (
!isAzurePackage({ options }) &&
emitterOptions["is-modular-library"] !== false
) {
options.isModularLibrary = true;
}
if (dpgContext.arm && emitterOptions["is-modular-library"] !== false) {
if (emitterOptions["is-modular-library"] !== false) {
options.isModularLibrary = true;
}
const batch = getRLCClients(dpgContext);
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/authentication/api-key/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ options:
flavor: azure
azure-sdk-for-js: false
is-typespec-test: true
is-modular-library: false
title: AuthApiKeyClient
package-details:
name: "@msinternal/auth-apikey"
Expand Down
1 change: 1 addition & 0 deletions ...ges/typespec-ts/test/azureIntegration/generated/authentication/http/custom/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ options:
flavor: azure
azure-sdk-for-js: false
is-typespec-test: true
is-modular-library: false
title: AuthHttpCustomClient
package-details:
name: "@msinternal/auth-httpcustom"
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/authentication/oauth2/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
flavor: azure
azure-sdk-for-js: false
is-typespec-test: true
is-modular-library: false
title: AuthOauth2Client
package-details:
name: "@msinternal/auth-oauth2"
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/authentication/union/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ options:
generate-test: true
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
title: AuthUnionClient
package-details:
Expand Down
1 change: 1 addition & 0 deletions ...spec-ts/test/azureIntegration/generated/azure/client-generator-core/access/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
generate-sample: true
package-details:
Expand Down
1 change: 1 addition & 0 deletions ...ureIntegration/generated/azure/client-generator-core/client-initialization/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ options:
emitter-output-dir: "{project-root}"
add-credentials: false
azure-sdk-for-js: false
is-modular-library: false
package-details:
name: "@azure/client-generator-core-initialization"
version: "1.0.0"
1 change: 1 addition & 0 deletions ...est/azureIntegration/generated/azure/client-generator-core/client-location/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ options:
emitter-output-dir: "{project-root}"
add-credentials: false
azure-sdk-for-js: false
is-modular-library: false
package-details:
name: "@azure/client-generator-core-location"
version: "1.0.0"
1 change: 1 addition & 0 deletions ...ion/generated/azure/client-generator-core/deserialize-empty-string-as-null/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ options:
emitter-output-dir: "{project-root}"
add-credentials: false
azure-sdk-for-js: false
is-modular-library: false
package-details:
name: "@azure/client-generator-core-deserialize-empty-string-as-null"
version: "1.0.0"
1 change: 1 addition & 0 deletions ...st/azureIntegration/generated/azure/client-generator-core/flatten-property/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
package-details:
name: "@msinternal/flatten-property"
Expand Down
1 change: 1 addition & 0 deletions ...espec-ts/test/azureIntegration/generated/azure/client-generator-core/usage/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
generate-sample: true
package-details:
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/azure/core/basic/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
generate-sample: true
title: AzureCoreClient
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/azure/core/lro/rpc/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
package-details:
name: "@msinternal/lro-rpc"
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/azure/core/lro/standard/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
package-details:
name: "@msinternal/lro-core"
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/azure/core/model/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
title: AzureCoreModelClient
package-details:
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/azure/core/page/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
title: AzureCorePageClient
package-details:
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/azure/core/scalar/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
title: AzureCoreScalarClient
package-details:
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/azure/core/traits/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
title: AzureCoreTraitsClient
package-details:
Expand Down
1 change: 1 addition & 0 deletions ...ts/test/azureIntegration/generated/azure/special-headers/client-request-id/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
package-details:
name: "@msinternal/media-types"
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/client/namespace/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
package-details:
name: "@msinternal/client-namespace"
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/client/naming/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
package-details:
name: "@msinternal/client-naming"
Expand Down
1 change: 1 addition & 0 deletions ...ts/test/azureIntegration/generated/client/structure/client-operation-group/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
package-details:
name: "@msinternal/client-operation-group"
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/client/structure/default/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
package-details:
name: "@msinternal/client-structure-default"
Expand Down
1 change: 1 addition & 0 deletions .../typespec-ts/test/azureIntegration/generated/client/structure/multi-client/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
package-details:
name: "@msinternal/client-structure-multiclient"
Expand Down
1 change: 1 addition & 0 deletions ...spec-ts/test/azureIntegration/generated/client/structure/renamed-operation/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
package-details:
name: "@msinternal/client-structure-renamed"
Expand Down
1 change: 1 addition & 0 deletions ...ec-ts/test/azureIntegration/generated/client/structure/two-operation-group/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
package-details:
name: "@msinternal/client-structure-twoopgroup"
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/encode/bytes/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
enable-operation-group: true
package-details:
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/encode/datetime/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
enable-operation-group: true
package-details:
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/encode/duration/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
enable-operation-group: true
package-details:
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/encode/numeric/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
enable-operation-group: true
package-details:
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/media-types/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
title: MediaTypesClient
package-details:
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/overload/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ options:
flavor: azure
azure-sdk-for-js: false
is-typespec-test: true
is-modular-library: false
package-details:
name: "@msinternal/media-types"
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/parameters/basic/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
enable-operation-group: true
is-typespec-test: true
package-details:
Expand Down
1 change: 1 addition & 0 deletions ...es/typespec-ts/test/azureIntegration/generated/parameters/body-optionality/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
enable-operation-group: true
is-typespec-test: true
package-details:
Expand Down
1 change: 1 addition & 0 deletions ...s/typespec-ts/test/azureIntegration/generated/parameters/collection-format/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
enable-operation-group: true
compatibility-query-multi-format: true
is-typespec-test: true
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/parameters/spread/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
enable-operation-group: true
is-typespec-test: true
package-details:
Expand Down
1 change: 1 addition & 0 deletions ...es/typespec-ts/test/azureIntegration/generated/payload/content-negotiation/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
enable-operation-group: true
package-details:
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/payload/media-type/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
enable-operation-group: true
package-details:
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-ts/test/azureIntegration/generated/payload/multipart/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ options:
add-credentials: false
flavor: azure
azure-sdk-for-js: false
is-modular-library: false
is-typespec-test: true
enable-operation-group: true
package-details:
Expand Down
Loading
Loading