Fix discriminated union property access to use camelCase property names #3447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discriminated union serializers were using the original PascalCase property names from TypeSpec (e.g.,
DocumentType
) in switch statements, but the generated TypeScript interfaces use camelCase property names (e.g.,documentType
). This caused TypeScript compilation errors:Consider this TypeSpec definition:
Previously, the generated serializer would incorrectly use:
Now it correctly uses:
Changes made:
buildSerializerFunction.ts
to usenormalizeName(discriminatorProperty.name, NameType.Property)
in switch statementsbuildDeserializerFunction.ts
to usenormalizeName(discriminatorProperty.name, NameType.Property)
in switch statementsThe fix ensures that discriminated union serializers and deserializers correctly access discriminator properties using the normalized camelCase names that match the generated TypeScript interface properties.
Fixes #3435.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.