Skip to content

Conversation

idanielsteven
Copy link
Contributor

Updating nexusidentity - Resolves installation issue caused by Graphs Python SDK package where a long path error occured. To fix this - SDK support was removed and replaced with httpclient


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

… Python SDK package where a long path error occured. To fix this - SDK support was removed and replaced with httpclient
@Copilot Copilot AI review requested due to automatic review settings August 28, 2025 16:40
Copy link

azure-client-tools-bot-prd bot commented Aug 28, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 28, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR resolves installation issues in the nexusidentity extension caused by the Microsoft Graph Python SDK package. The solution involves removing the Graph SDK dependency and replacing it with direct HTTP client calls to the Microsoft Graph API.

Key Changes

  • Removed the msgraph-sdk dependency from setup.py
  • Replaced SDK-based Graph API calls with direct HTTP requests using the requests library
  • Updated version from 1.0.0b5 to 1.0.0b6

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/nexusidentity/setup.py Version bump and removal of msgraph-sdk dependency
src/nexusidentity/azext_nexusidentity/custom.py Complete replacement of Graph SDK calls with HTTP requests
src/nexusidentity/HISTORY.rst Documentation of the changes in version 1.0.0b6

Copy link

@necusjz necusjz merged commit 55aa877 into Azure:main Sep 16, 2025
25 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ nexusidentity-1.0.0b6 ] : https://dev.azure.com/msazure/One/_build/results?buildId=137316991&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants