-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Updating nexusidentity - Resolves installation issue caused by Graphs Python SDK package. #9102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… Python SDK package where a long path error occured. To fix this - SDK support was removed and replaced with httpclient
️✔️Azure CLI Extensions Breaking Change Test
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR resolves installation issues in the nexusidentity extension caused by the Microsoft Graph Python SDK package. The solution involves removing the Graph SDK dependency and replacing it with direct HTTP client calls to the Microsoft Graph API.
Key Changes
- Removed the
msgraph-sdk
dependency from setup.py - Replaced SDK-based Graph API calls with direct HTTP requests using the
requests
library - Updated version from 1.0.0b5 to 1.0.0b6
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
src/nexusidentity/setup.py | Version bump and removal of msgraph-sdk dependency |
src/nexusidentity/azext_nexusidentity/custom.py | Complete replacement of Graph SDK calls with HTTP requests |
src/nexusidentity/HISTORY.rst | Documentation of the changes in version 1.0.0b6 |
|
[Release] Update index.json for extension [ nexusidentity-1.0.0b6 ] : https://dev.azure.com/msazure/One/_build/results?buildId=137316991&view=results |
Updating nexusidentity - Resolves installation issue caused by Graphs Python SDK package where a long path error occured. To fix this - SDK support was removed and replaced with httpclient
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.