-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Feature/aks acns performance #9136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/aks acns performance #9136
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter acns_datapath_acceleration_mode |
||
| aks update | cmd aks update added parameter acns_datapath_acceleration_mode |
|
Hi @santhoshmprabhu, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for ACNS (Azure Container Networking Services) performance acceleration mode, enabling users to configure BPF-based networking acceleration for improved performance. The feature introduces a new --acns-performance-acceleration-mode parameter with values 'None' and 'BpfVeth'.
Key changes include:
- Added new parameter
acns_performance_acceleration_modeto bothaz aks createandaz aks updatecommands - Extended ACNS enablement logic to handle performance acceleration as a fourth dimension alongside security and observability
- Updated validation to ensure performance acceleration requires ACNS to be enabled
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| _consts.py | Added constants for ACNS performance acceleration mode values |
| _params.py | Added parameter definition and validation for the new acceleration mode option |
| _help.py | Added documentation for the new parameter in both create and update commands |
| custom.py | Added the new parameter to function signatures |
| managed_cluster_decorator.py | Extended ACNS enablement logic and network profile setup to handle performance acceleration |
| test_managed_cluster_decorator.py | Updated tests to handle the new fourth return value from get_acns_enablement() |
| linter_exclusions.yml | Added exclusions for the long parameter name |
| HISTORY.rst | Added changelog entry for the new feature |
src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
|
Co-authored-by: Copilot <[email protected]>
…uster_decorator.py Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a new scenario test case (see examples in test_aks_commands.py) for the newly added option?
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Please enable the toggle for at least some test subs to verify the change. If the feature is not available anywhere, what's point of adding it to aks-preview? |
|
@FumingZhang I've added the test, I have the release in progress for one test sub. I'll leave a comment once the release reaches the intended region. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| name_prefix="clitest", | ||
| location="westcentralus", | ||
| ) | ||
| def test_aks_create_with_acns_performance( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Queued live test to validate the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the live test passes, please find the recording file from pipeline artifact and commit it to your branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked in the recording file from my local run. Please let me know if that does not suffice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-queued live test, test passed!
|
@FumingZhang The release is in progress, and I'm using a region where the feature is now enabled for the test sub. The tests passed locally (checked in the recording). Please take another look. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@microsoft-github-policy-service rerun |
|
please resolve the code conflicts. |
Done |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ aks-preview-18.0.0b38 ] : https://dev.azure.com/msazure/One/_build/results?buildId=137487000&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.