Skip to content

Conversation

@santhoshmprabhu
Copy link
Contributor

@santhoshmprabhu santhoshmprabhu commented Sep 5, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create --enable-acns --acns-datapath-acceleration-mode BpfVeth
az aks update --acns-datapath-acceleration-made None

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings September 5, 2025 19:35
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 5, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter acns_datapath_acceleration_mode
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter acns_datapath_acceleration_mode

@azure-client-tools-bot-prd
Copy link

Hi @santhoshmprabhu,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 5, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Sep 5, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for ACNS (Azure Container Networking Services) performance acceleration mode, enabling users to configure BPF-based networking acceleration for improved performance. The feature introduces a new --acns-performance-acceleration-mode parameter with values 'None' and 'BpfVeth'.

Key changes include:

  • Added new parameter acns_performance_acceleration_mode to both az aks create and az aks update commands
  • Extended ACNS enablement logic to handle performance acceleration as a fourth dimension alongside security and observability
  • Updated validation to ensure performance acceleration requires ACNS to be enabled

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
_consts.py Added constants for ACNS performance acceleration mode values
_params.py Added parameter definition and validation for the new acceleration mode option
_help.py Added documentation for the new parameter in both create and update commands
custom.py Added the new parameter to function signatures
managed_cluster_decorator.py Extended ACNS enablement logic and network profile setup to handle performance acceleration
test_managed_cluster_decorator.py Updated tests to handle the new fourth return value from get_acns_enablement()
linter_exclusions.yml Added exclusions for the long parameter name
HISTORY.rst Added changelog entry for the new feature

@github-actions
Copy link

github-actions bot commented Sep 5, 2025

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a new scenario test case (see examples in test_aks_commands.py) for the newly added option?

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang
Copy link
Member

Could you please add a new scenario test case (see examples in test_aks_commands.py) for the newly added option?

@FumingZhang, this feature is currently disabled by toggle, would we still be able to use test_aks_commands?

Please enable the toggle for at least some test subs to verify the change. If the feature is not available anywhere, what's point of adding it to aks-preview?

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 14, 2025
@santhoshmprabhu
Copy link
Contributor Author

@FumingZhang I've added the test, I have the release in progress for one test sub. I'll leave a comment once the release reaches the intended region.

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 14, 2025
@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

name_prefix="clitest",
location="westcentralus",
)
def test_aks_create_with_acns_performance(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the live test passes, please find the recording file from pipeline artifact and commit it to your branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked in the recording file from my local run. Please let me know if that does not suffice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-queued live test, test passed!

@santhoshmprabhu
Copy link
Contributor Author

@FumingZhang The release is in progress, and I'm using a region where the feature is now enabled for the test sub. The tests passed locally (checked in the recording). Please take another look.

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang
Copy link
Member

@microsoft-github-policy-service rerun

@yanzhudd
Copy link
Contributor

please resolve the code conflicts.

@santhoshmprabhu
Copy link
Contributor Author

please resolve the code conflicts.

Done

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@zhoxing-ms zhoxing-ms merged commit b06cbbb into Azure:main Sep 18, 2025
25 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview-18.0.0b38 ] : https://dev.azure.com/msazure/One/_build/results?buildId=137487000&view=results

@santhoshmprabhu santhoshmprabhu deleted the feature/aks-acns-performance branch September 18, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants