Skip to content

Conversation

B-Oudehinken
Copy link
Contributor

@B-Oudehinken B-Oudehinken commented Sep 5, 2025

Forgot to update the ruletype in my previous pr.

This pull request updates the type references for ruleType in the Update-AzRoleManagementPolicy.md help documentation to use the fully qualified name Microsoft.Azure.PowerShell.Cmdlets.Resources.Authorization.Support.RoleManagementPolicyRuleType. This ensures clarity and prevents potential type resolution conflicts.

Type reference updates:

  • Changed the ruleType assignment for expiration rules to use the fully qualified RoleManagementPolicyRuleType instead of the unqualified version. (src/Resources/Resources/help/Update-AzRoleManagementPolicy.md) [1] [2]
  • Updated the ruleType assignment for notification rules to use the fully qualified RoleManagementPolicyRuleType. (src/Resources/Resources/help/Update-AzRoleManagementPolicy.md)

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Forgot to update the ruletype in my previous pr.
@Copilot Copilot AI review requested due to automatic review settings September 5, 2025 10:05
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates type references in PowerShell help documentation to use fully qualified type names for better clarity and to prevent potential type resolution conflicts.

  • Updates ruleType assignments to use the fully qualified Microsoft.Azure.PowerShell.Cmdlets.Resources.Authorization.Support.RoleManagementPolicyRuleType instead of the unqualified RoleManagementPolicyRuleType

Copy link
Contributor

Thank you for your contribution @B-Oudehinken! We will review the pull request and get back to you soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant