Skip to content

Conversation

iliu816
Copy link
Member

@iliu816 iliu816 commented Sep 5, 2025

Description

[Az.ServiceFabric] Renamed Remove-AzServiceFabricManagedNodeType parameter sets to use "Remove" instead of "Delete" for consistency with cmdlet name.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

…meter sets to use "Remove" instead of "Delete" for consistency with cmdlet name.
@Copilot Copilot AI review requested due to automatic review settings September 5, 2025 16:17
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves naming consistency in the Remove-AzServiceFabricManagedNodeType cmdlet by renaming all parameter sets from using "Delete" prefixes to "Remove" prefixes, aligning them with the cmdlet's verb.

  • Renamed six parameter set constants from "Delete*" to "Remove*" patterns
  • Updated all parameter set references throughout the codebase and help documentation
  • Updated action messages to use "Remove" terminology consistently

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
RemoveAzServiceFabricManagedNodeType.cs Updated parameter set constant names and all references from "Delete*" to "Remove*" patterns
Remove-AzServiceFabricManagedNodeType.md Updated help documentation to reflect the new parameter set names
ChangeLog.md Added changelog entry documenting the parameter set renaming
Comments suppressed due to low confidence (1)

src/ServiceFabric/ServiceFabric/Commands/ManagedClusters/NodeTypes/RemoveAzServiceFabricManagedNodeType.cs:111

  • There is a spelling error in the HelpMessage on lines 85, 87, and 89. 'opearion' should be 'operation'.
                        if (ShouldProcess(target: this.Name, action: string.Format("Remove node(s) {0}, from node type {1} on cluster {2}", string.Join(", ", this.NodeName), this.Name, this.ClusterName)))

@isra-fel
Copy link
Member

isra-fel commented Sep 5, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly self-assigned this Sep 9, 2025
@VeryEarly VeryEarly merged commit c19b30e into Azure:main Sep 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants